Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

UTF8 characters break node #15

Closed
ujh opened this issue Jul 12, 2009 · 1 comment
Closed

UTF8 characters break node #15

ujh opened this issue Jul 12, 2009 · 1 comment

Comments

@ujh
Copy link

ujh commented Jul 12, 2009

See http://groups.google.com/group/nodejs/browse_thread/thread/4d8a823f19348c0a

@ry
Copy link

ry commented Jul 20, 2009

Fixed in b1588e7.

HenryRawas pushed a commit to HenryRawas/node that referenced this issue Jun 22, 2011
jianchun referenced this issue in microsoft/node-v0.12 May 11, 2015
These changes are mostly proposed by Alexis Campailla (orangemocha).

build: Change the specific node_use_chakra flag to more general
node_engine variable.

common.gypi: Add node_engine_include_dir variable for clients that need
v8 headers (debugger-agent.gyp and node-gyp addon.gypi). Define
NODE_ENGINE symbol and NODE_ENGINE_V8/NODE_ENGINE_CHAKRA flags
respectively, used in node.cc.

node.cc: Add runtime property process.jsEngine and use everywhere js
engine check is needed.

chakrashim.gyp: add WIN10 requirement.

js2c.py: replace "-chakra" flag to more general "--namespace=..."
switch.

node-gyp: add --node_engine switch, default to process.jsEngine and
fall back to "v8".

Reviewed-By: orangemocha
PR-URL: [#15](https://github.com/Microsoft/node-msft/pull/15)
jianchun referenced this issue in microsoft/node-v0.12 May 29, 2015
These changes are mostly proposed by Alexis Campailla (orangemocha).

build: Change the specific node_use_chakra flag to more general
node_engine variable.

common.gypi: Add node_engine_include_dir variable for clients that need
v8 headers (debugger-agent.gyp and node-gyp addon.gypi). Define
NODE_ENGINE symbol and NODE_ENGINE_V8/NODE_ENGINE_CHAKRA flags
respectively, used in node.cc.

node.cc: Add runtime property process.jsEngine and use everywhere js
engine check is needed.

chakrashim.gyp: add WIN10 requirement.

js2c.py: replace "-chakra" flag to more general "--namespace=..."
switch.

node-gyp: add --node_engine switch, default to process.jsEngine and
fall back to "v8".

Reviewed-By: orangemocha
PR-URL: [#15](https://github.com/Microsoft/node-msft/pull/15)
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants