This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
resumeSession hangs when no session data passed to callback in 0.12 #25735
Comments
cc @indutny |
Should be fixed by back-porting nodejs/node@963f5e8a . @joyent/node-collaborators : may I ask you to give it a quick LGTM, if it LGTY? |
LGTM |
@jasnell should I just cherry-pick it, or is there some tool that I need to run before doing this? |
Looks good. We should probably add a couple of tests covering the issues I opened. |
Ok, I'll send a PR then. |
indutny
added a commit
to indutny/node
that referenced
this issue
Jul 18, 2015
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: nodejs#8660 Fi: nodejs#25735 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: node-forward/node#47
indutny
added a commit
to indutny/node
that referenced
this issue
Jul 18, 2015
indutny
added a commit
to indutny/node
that referenced
this issue
Jul 18, 2015
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: nodejs#8660 Fix: nodejs#25735 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: node-forward/node#47
indutny
added a commit
to indutny/node
that referenced
this issue
Jul 18, 2015
indutny
added a commit
to indutny/node
that referenced
this issue
Jul 20, 2015
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this issue
Nov 4, 2016
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: nodejs#8660 Fix: nodejs#25735 Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: nodejs#25739
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this issue
Nov 4, 2016
See: nodejs#25736 Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: nodejs#25739
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Example, this will work in 0.10:
And hang in 0.12.
Passing no session data back should cause a new session to be created.
The text was updated successfully, but these errors were encountered: