Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

resumeSession hangs when no session data passed to callback in 0.12 #25735

Closed
tlivings opened this issue Jul 18, 2015 · 7 comments
Closed

resumeSession hangs when no session data passed to callback in 0.12 #25735

tlivings opened this issue Jul 18, 2015 · 7 comments

Comments

@tlivings
Copy link

Example, this will work in 0.10:

'use strict';

var Https = require('https');
var Fs = require('fs');

var server = Https.createServer({
    cert: Fs.readFileSync('server.crt'),
    key: Fs.readFileSync('server.key')
}, function (req, res) {
    res.writeHead(200);
    res.end("hello world\n");
});

server.on('resumeSession', function (id, callback) {
    console.log('resume requested');
    callback();
});

server.listen(8000);

And hang in 0.12.

Passing no session data back should cause a new session to be created.

@tlivings
Copy link
Author

cc @indutny

@indutny
Copy link
Member

indutny commented Jul 18, 2015

Should be fixed by back-porting nodejs/node@963f5e8a . @joyent/node-collaborators : may I ask you to give it a quick LGTM, if it LGTY?

@jasnell
Copy link
Member

jasnell commented Jul 18, 2015

LGTM

@indutny
Copy link
Member

indutny commented Jul 18, 2015

@jasnell should I just cherry-pick it, or is there some tool that I need to run before doing this?

@tlivings
Copy link
Author

Looks good. We should probably add a couple of tests covering the issues I opened.

@indutny
Copy link
Member

indutny commented Jul 18, 2015

Ok, I'll send a PR then.

indutny added a commit to indutny/node that referenced this issue Jul 18, 2015
When listening for client hello parser events (like OCSP requests), do
not hang if `newSession` event handler is not present.

Fix: nodejs#8660
Fi: nodejs#25735
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: node-forward/node#47
indutny added a commit to indutny/node that referenced this issue Jul 18, 2015
indutny added a commit to indutny/node that referenced this issue Jul 18, 2015
When listening for client hello parser events (like OCSP requests), do
not hang if `newSession` event handler is not present.

Fix: nodejs#8660
Fix: nodejs#25735
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: node-forward/node#47
indutny added a commit to indutny/node that referenced this issue Jul 18, 2015
@indutny
Copy link
Member

indutny commented Jul 18, 2015

@tlivings here you go #25739

indutny added a commit to indutny/node that referenced this issue Jul 20, 2015
indutny added a commit that referenced this issue Jul 20, 2015
When listening for client hello parser events (like OCSP requests), do
not hang if `newSession` event handler is not present.

Fix: #8660
Fix: #25735

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #25739
indutny added a commit that referenced this issue Jul 20, 2015
See: #25736

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #25739
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
When listening for client hello parser events (like OCSP requests), do
not hang if `newSession` event handler is not present.

Fix: nodejs#8660
Fix: nodejs#25735

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: nodejs#25739
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
See: nodejs#25736

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: nodejs#25739
@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants