This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Tests for joyent/node#5141 not working as advertised #5183
Comments
arhart
added a commit
to arhart/node-v0.x-archive
that referenced
this issue
Mar 31, 2013
The tests did not agree with the test comments. Tests first and second were both testing the !state.reading case. Now second tests the state.reading && state.length case. Fixes nodejs#5183
|
CLA submitted |
isaacs
pushed a commit
to isaacs/node-v0.x-archive
that referenced
this issue
Apr 1, 2013
The tests did not agree with the test comments. Tests first and second were both testing the !state.reading case. Now second tests the state.reading && state.length case. Fixes nodejs#5183
|
Landed on db8ce89. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The tests for #5141 do not agree with the test comments. Of particular concern, first and second both test the !state.readign case, meaning second misses the state.reading && state.length case.
In other words,
can be removed from Readable.prototype.on and the tests would not fail.
I'll try to work up a pull request, but this'll be my first time so it might be awhile.
I've not yet submitted the CLA.
The text was updated successfully, but these errors were encountered: