Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Server::Listen returns Undefined regardless of result from bind #54

Closed
tautologistics opened this issue Jan 29, 2010 · 4 comments
Closed

Comments

@tautologistics
Copy link

There's no way to know whether the bind to the address/port was successful. See:

http://groups.google.com/group/nodejs/browse_thread/thread/8f48798d8cc6cd15

@tautologistics
Copy link
Author

http://github.com/tautologistics/node/commit/625c219e3bc8e1b8836f3953a3bff3c018c1e0fa

Changes are to:

deps/evcom/evcom.c
src/node_net.cc

Listen() now returns a boolean indicating the success/failure of the underlying bind (unless someone thinks it would be better to return the raw int result).

Ryan - what way do you find is easiest for you to receive changes? Github push requests, posts here, updates to the issue tracker, or something else?

@ry
Copy link

ry commented Feb 6, 2010

is this still an issue?

i prefer patches on the mailing list

@tautologistics
Copy link
Author

With 0.1.27, no; it still returns undefined with no exception on failure. With the net2 patch you pointed me to, yes, bind failures are detectable.

@ry
Copy link

ry commented Feb 8, 2010

fixed in 77145ba

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants