child_process.spawn optional arguments

[alexwhitman]

The documentation for child_process.spawn() (http://www.nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options) suggests that both the args and options arguments are optional. However spawn('ls', { cwd: process.cwd() }) errors with

child_process.js:699
  args = args ? args.slice(0) : [];
                     ^
TypeError: Object #<Object> has no method 'slice'

It can be worked around with spawn('ls', [], { cwd: process.cwd() }).

This is on 0.10.16.

[cdokolas]

Methinks the correct syntax is spawn('ls', undefined, { cwd: process.cwd() }).

[cjihrig]

This appears to be fixed in at least v0.11.13. Recommend closing. These both work:

Without optional args:

var cp = require('child_process');
var child = cp.spawn('ls', {cwd: '/'});

child.stdout.on('data', function (data) {
  console.log(data.toString());
});

With args:

var cp = require('child_process');
var child = cp.spawn('ls', ['-la'], {cwd: '/'});

child.stdout.on('data', function (data) {
  console.log(data.toString());
});

[trevnorris]

PR to fix this on v0.10 would be accepted.

[cjihrig]

@trevnorris added a fix for 0.10. I think some cleanup could be done in the latest version. I plan to work on that, if it would be welcomed.

[trevnorris]

@cjihrig Generally we don't do code cleanup unless it causes the style check to fail, or if the code is being worked on for other reasons. Mainly because it makes life more difficult when trying to trace through a file using git blame.

[cjihrig]

@trevnorris Sorry, I should have been more clear. I didn't mean style fixes. I meant things like this line, which could be simplified down to var env = options.env || process.env;. If you're still not interested, no big deal.

[trevnorris]

Fixed by 542ac7f.

[trevnorris]

@cjihrig That line doesn't even make sense. Yeah, logic check fixes are good.