This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
dns/net: dns lookups cannot be unref'd #7149
Milestone
Comments
I like the idea of cancelable and It seems that similar to how internal timers are always I would entertain a PR for this, maybe something that exposes the internal lookup with a flag indicating it should be |
It would have to be fixed in libuv first because currently you can't unref requests. (At least, I never added that and it doesn't look like it's in there now.) I don't think I'll have time to work on that anytime soon but if e.g. @indutny wants to pick it up, I can review the PR. |
Something for a future, perhaps, don't have time for this now. |
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Jun 17, 2016
Notable changes: * **http**: - req.read(0) could cause incoming connections to stall and time out under certain conditions. (Fedor Indutny) [nodejs#7211](nodejs/node#7211) - When freeing the socket to be reused in keep-alive Agent wait for both prefinish and end events. Otherwise the next request may be written before the previous one has finished sending the body, leading to a parser errors. (Fedor Indutny) [nodejs#7149](nodejs/node#7149) * **npm**: upgrade npm to 3.9.5 (Kat Marchán) [nodejs#7139](nodejs/node#7139) nodejs/node#7323
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this issue
Jun 17, 2016
Notable changes: * **http**: - req.read(0) could cause incoming connections to stall and time out under certain conditions. (Fedor Indutny) [nodejs#7211](nodejs/node#7211) - When freeing the socket to be reused in keep-alive Agent wait for both prefinish and end events. Otherwise the next request may be written before the previous one has finished sending the body, leading to a parser errors. (Fedor Indutny) [nodejs#7149](nodejs/node#7149) * **npm**: upgrade npm to 3.9.5 (Kat Marchán) [nodejs#7139](nodejs/node#7139) nodejs/node#7323
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this issue
Jun 20, 2016
Notable changes: * **http**: - req.read(0) could cause incoming connections to stall and time out under certain conditions. (Fedor Indutny) [nodejs#7211](nodejs/node#7211) - When freeing the socket to be reused in keep-alive Agent wait for both prefinish and end events. Otherwise the next request may be written before the previous one has finished sending the body, leading to a parser errors. (Fedor Indutny) [nodejs#7149](nodejs/node#7149) * **npm**: upgrade npm to 3.9.5 (Kat Marchán) [nodejs#7139](nodejs/node#7139) PR-URL: nodejs/node#7323
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Sorry, I don't have a simple test case that won't involve mount binding /etc/resolv.conf but the issue is simple enough:
If the resolver is slow to reply, the event loop remains alive for a potentially long time (glibc times out after 5-30 seconds, other resolvers may be worse.)
Somewhat related to #7077.
The text was updated successfully, but these errors were encountered: