This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Fails to build when '--without-ssl' configure option set #8645
Comments
Cannot reproduce, OS X 10.10. |
Same error occurs in Ubuntu 14.04. |
Same error on Gentoo when emerging with the disabled ssl flag: |
/cc @nodejs/crypto @nodejs/build this seems like something we can and should fix for 0.12, seems like just a missing |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
Nov 14, 2015
Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: nodejs/node-v0.x-archive#8645
jasnell
pushed a commit
to jasnell/node
that referenced
this issue
Nov 15, 2015
Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: nodejs/node-v0.x-archive#8645 PR-URL: nodejs#3825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
added a commit
to nodejs/node
that referenced
this issue
Nov 15, 2015
Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: nodejs/node-v0.x-archive#8645 PR-URL: #3825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this issue
Nov 4, 2016
Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: nodejs#8645 PR-URL: nodejs/node#3825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I see the following error message in the build log:
out/Release/obj.target/node/src/node.o: In function
ParseArgs': out/../src/node.cc:2583: undefined reference to
node::SSL2_ENABLE'out/../src/node.cc:2586: undefined reference to `node::SSL3_ENABLE'
collect2: error: ld returned 1 exit status
gmake[1]: *** [out/Release/node] Error 1
The following patch appears to fix this:
diff --git a/src/node.cc b/src/node.cc
index 18c743f..44026e2 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -2544,8 +2544,10 @@ static void PrintHelp() {
" --trace-deprecation show stack traces on deprecations\n"
" --v8-options print v8 command line options\n"
" --max-stack-size=val set max v8 stack size (bytes)\n"
+#if HAVE_OPENSSL
" --enable-ssl2 enable ssl2\n"
" --enable-ssl3 enable ssl3\n"
+#endif
"\n"
"Environment variables:\n"
#ifdef _WIN32
@@ -2579,12 +2581,14 @@ static void ParseArgs(int argc, char argv) {
p = 1 + strchr(arg, '=');
max_stack_size = atoi(p);
argv[i] = const_cast<char>("");
+#if HAVE_OPENSSL
} else if (strcmp(arg, "--enable-ssl2") == 0) {
SSL2_ENABLE = true;
argv[i] = const_cast<char>("");
} else if (strcmp(arg, "--enable-ssl3") == 0) {
SSL3_ENABLE = true;
argv[i] = const_cast<char*>("");
+#endif
} else if (strcmp(arg, "--help") == 0 || strcmp(arg, "-h") == 0) {
PrintHelp();
exit(0);
The text was updated successfully, but these errors were encountered: