This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
vcbuild.bat's build-release target should enable small-icu and download ICU if needed #9099
Comments
misterdjules
pushed a commit
to misterdjules/node
that referenced
this issue
Jan 26, 2015
On Windows, when building the "build-release" rule, enable both small-icu and download-all. This change also slightly refactors the build-release rule, mainly so that it's easier to read. The resulting MSI package was tested on Windows 7. Fixes nodejs#9099.
misterdjules
pushed a commit
that referenced
this issue
Jan 26, 2015
On Windows, when building the "build-release" rule, enable both small-icu and download-all. This change also slightly refactors the build-release rule, mainly so that it's easier to read. The resulting MSI package was tested on Windows 7. Fixes #9099. PR: #9100 PR-URL: #9100 Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
|
Fixed by e670732. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A recent merge of v0.10 into v0.12 added a new "build-release" rule to vcbuild.bat. v0.10 doesn't support ICU, but v0.12 does and the
build-releaseshould enable bothsmall-icuanddownload-allin this branch.The text was updated successfully, but these errors were encountered: