Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Fix with --harmony-weakmaps #1529

Closed
wants to merge 1 commit into from
Closed

Fix with --harmony-weakmaps #1529

wants to merge 1 commit into from

Conversation

koichik
Copy link

@koichik koichik commented Aug 14, 2011

With --harmony-weakmaps command line option, util.inherits throws TypeError.
reproduce:

$ node --harmony-weakmaps

util.js:467
  ctor.prototype = Object.create(superCtor.prototype, {
                          ^
TypeError: Invalid property.  A property cannot both have accessors and be writable or have a value: #<WeakMap>
    at Function.create (native)
    at WeakMap.inherits (util.js:467:27)
    at assert.js:52:6
    at NativeModule.compile (node.js:502:5)
    at node.js:467:18
    at buffer.js:23:14
    at NativeModule.compile (node.js:502:5)
    at Function.require (node.js:467:18)
    at Function.globalVariables (node.js:137:34)
    at startup (node.js:48:13)

With --harmony-weakmaps, util.inherits throws TypeError.
@koichik
Copy link
Author

koichik commented Aug 14, 2011

please review.

@isaacs
Copy link

isaacs commented Aug 14, 2011

I think this is really a bug in v8 somewhere. The error message makes no sense.

Posted upstream: http://code.google.com/p/v8/issues/detail?id=1617

If we apply this patch,

  1. inherits will make the constructor properties unwritable.
  2. Object.create is still broken in v8.

-1.

@isaacs isaacs closed this Aug 14, 2011
@koichik
Copy link
Author

koichik commented Aug 15, 2011

Posted upstream: http://code.google.com/p/v8/issues/detail?id=1617

Thanks!

lyonplus pushed a commit to lyonplus/node that referenced this pull request May 22, 2015
PR-URL: nodejs/node#1532

Notable Changes:

* crypto: significantly reduced memory usage for TLS (Fedor Indutny & Сковорода
  Никита Андреевич) nodejs#1529
* net: socket.connect() now accepts a 'lookup' option for a custom DNS
  resolution mechanism, defaults to dns.lookup() (Evan Lucas) nodejs#1505
* npm: Upgrade npm to 2.9.0. See the v2.8.4 and v2.9.0 release notes for
  details. Notable items:
  - Add support for default author field to make npm init -y work without
    user-input (@othiym23) npm/npm/d8eee6cf9d
  - Include local modules in npm outdated and npm update (@ArnaudRinquin)
    npm/npm#7426
  - The prefix used before the version number on npm version is now configurable
    via tag-version-prefix (@kkragenbrink) npm/npm#8014
* os: os.tmpdir() is now cross-platform consistent and will no longer returns a
  path with a trailling slash on any platform (Christian Tellnes) nodejs#747
* process:
  - process.nextTick() performance has been improved by between 2-42% across the
    benchmark suite, notable because this is heavily used across core (Brian White) nodejs#1548
  - New process.geteuid(), process.seteuid(id), process.getegid() and
    process.setegid(id) methods allow you to get and set effective UID and GID
    of the process (Evan Lucas) nodejs#1536
* repl:
  - REPL history can be persisted across sessions if the NODE_REPL_HISTORY_FILE
    environment variable is set to a user accessible file,
    NODE_REPL_HISTORY_SIZE can set the maximum history size and defaults to 1000
    (Chris Dickinson) nodejs#1513
  - The REPL can be placed in to one of three modes using the NODE_REPL_MODE
    environment variable: sloppy, strict or magic (default); the new magic mode
    will automatically run "strict mode only" statements in strict mode
    (Chris Dickinson) nodejs#1513
* smalloc: the 'smalloc' module has been deprecated due to changes coming in V8
  4.4 that will render it unusable
* util: add Promise, Map and Set inspection support (Christopher Monsanto) nodejs#1471
* V8: upgrade to 4.2.77.18, see the ChangeLog for full details. Notable items:
  - Classes have moved out of staging; the class keyword is now usable in strict
    mode without flags
  - Object literal enhancements have moved out of staging; shorthand method and
    property syntax is now usable ({ method() { }, property })
  - Rest parameters (function(...args) {}) are implemented in staging behind the
    --harmony-rest-parameters flag
  - Computed property names ({['foo'+'bar']:'bam'}) are implemented in staging
    behind the --harmony-computed-property-names flag
  - Unicode escapes ('\u{xxxx}') are implemented in staging behind the
    --harmony_unicode flag and the --harmony_unicode_regexps flag for use in
    regular expressions
* Windows:
  - Random process termination on Windows fixed (Fedor Indutny) nodejs#1512 / nodejs#1563
  - The delay-load hook introduced to fix issues with process naming (iojs.exe /
    node.exe) has been made opt-out for native add-ons. Native add-ons should
    include 'win_delay_load_hook': 'false' in their binding.gyp to disable this
    feature if they experience problems . (Bert Belder) nodejs#1433
* Governance:
  - Rod Vagg (@rvagg) was added to the Technical Committee (TC)
  - Jeremiah Senkpiel (@Fishrock123) was added to the Technical Committee (TC)
richardlau pushed a commit to ibmruntimes/node that referenced this pull request Sep 18, 2015
Maintenance release

Notable Changes:

* crypto: significantly reduced memory usage for TLS (Fedor Indutny &
  Сковорода Никита Андреевич) nodejs#1529
* npm: Upgrade npm to 2.9.0. See the v2.8.4 and v2.9.0 release notes for
  details.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants