This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
unguarded fs.watchFile cache statWatchers checking fixed #1637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.watchFile code had checks for cached previously seen filepaths where the
check was not adequately protected against property name collisions:
could have false positives if the filepath was a chained Object property
name, e.g. 'hasOwnProperty'. Wild-looking errors would ensue:
Fix is to use hasOwnProperty in both places cache checks are done:
Change updates lib/fs.js and test/simple/test-fs-watch-file.js