This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix util extend issue #25672
Closed
Fix util extend issue #25672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "origin" object argument is null or notdefined, _extend throws exception. Fix _extend to allow undefined "origin" object argument and return the "add" object argument.
When the "origin" object argument is null or notdefined, _extend throws exception. Fix _extend to allow undefined "origin" object argument and return the "add" object argument. Add new line at end of tests file
|
Unfortunately, I believe this ends up qualifying as an API change (even if only a small one). It would likely be better to target this at http://github.com/nodejs/io.js or http://github.com/nodejs/node. Also, the commits should be squashed. /cc @joyent/node-tsc |
|
Thanks, I've created a new PR with this fix at http://github.com/nodejs/node |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "origin" object argument is null or not defined, _extend
throws exception.
Fix _extend to allow undefined "origin" object argument and return
the "add" object argument.