Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

test: fix test-debug-port-from-cmdline #25748

Closed
wants to merge 1 commit into from
Closed

test: fix test-debug-port-from-cmdline #25748

wants to merge 1 commit into from

Commits on Jul 22, 2015

  1. test: fix test-debug-port-from-cmdline

    This change is a backport of 2b4b600
    from io.js.
    
    Original commit message:
    
      This test was failing because the spawned process was terminated
      before anything could be done, by calling child.stdin.end. With this
      change, the child's stdin is no longer closed. When the stdin is not
      a tty, io.js waits for the whole input before starting, so the child
      must be run with --interactive to process the command sent by the
      parent. The child is killed explicitly by the parent before it exits.
    
      This test was failing silently because the asserts were not called if
      nothing was received from the child. This fix moves assertOutputLines
      to always run on exit.
    
      Fixes: nodejs/node#2177
      Refs: nodejs/node#2094
      PR-URL: nodejs/node#2186
      Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
      Reviewed-By: Rod Vagg <rod@vagg.org>
      Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
      Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
    joaocgreis committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    2fe0bf5 View commit details
    Browse the repository at this point in the history