Update assert.markdown #25786
Update assert.markdown #25786
Conversation
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments.
|
SGTM |
|
Thanks. At 2015-07-31 06:01:25, "daveboivin" notifications@github.com wrote: The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing. The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments. You can view, comment on, or merge this pull request online at: Commit Summary — |
|
LGTM. I see this is targeted against master. I will land it both on master and the v0.12 branch. |
|
Thanks everyone. btw: I've now read the Contributing Documentation so I can follow to the guidelines better next time. |
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments.
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25786
|
Landed in 99414b3. Will cherry pick this into v0.12 as well. |
The current wording "This module is used for writing unit tests for your applications, you can access it with require('assert')." implies that this module should only be used in development while unit testing.
The article "Error Handling in Node.js" by Joyent (https://www.joyent.com/developers/node/design/errors) uses the assert module in an efficient way to validate required function arguments.