This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Include the node.lib file at link time on Windows. #2685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the basic `gyp_addon` script work with Windows. The "Debug" dir is currently hard-coded. A better way would be to use the currently selected "configuration" that gyp is executing, but I could not figure out how to get a variable of the configuration...
ghost
assigned 
|
@piscisaureus Ok I have updated this to use the proper "Configuration" value, and not be hard-coded. Tested and works. Works with |
TooTallNate
added a commit
to nodejs/node-gyp
that referenced
this pull request
Feb 6, 2012
…ts been merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the basic
gyp_addonscript work with Windows.The "Debug" dir is currently hard-coded. A better way would be to use the currently selected "configuration" that gyp is executing, but I could not figure out how to get a variable of the configuration. If someone knows a way to get the Debug/Release value through gyp then that would be great.