This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Add documentation about request.pause issue. #4305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of people (including myself before today) are under the impression request.stream.pause will prevent any more data events from being fired, hopefully they will see this before spending hours tracking down the bug.
| @@ -300,6 +300,7 @@ information. | |||
|
|
|||
| Pauses request from emitting events. Useful to throttle back an upload. | |||
|
|
|||
| Note: Data events may still be fired after the request is paused, see [this discussion](groups.google.com/group/nodejs/browse_thread/thread/cafe8397e3bec189) for more information. | |||
There was a problem hiding this comment.
Long line, wrap at 80 columns.
|
Can you fix the style issue and make the commit log conform to the common template? Check Also, can you sign the CLA? |
|
@koichik crap crap crap, looks like I am still on 0.6 on this computer. |
|
I'd be fine with taking this doc patch on v0.6 branch, but there might never be another 0.6 release, so it may be pointless. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of people (including myself before today) are under the impression request.stream.pause will prevent any more data events from being fired, hopefully they will see this before spending hours tracking down the bug.