This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #5860.
Performance-wise it seems to be on-par with master, and I haven't gone through and worked out any trouble spots with the V8 profiling tools.
The commits are a mess, and will be squashed of course, but the best way to see the high level view of what this enables is to check out https://github.com/isaacs/node/blob/streams3/test/simple/test-stream3-pause-then-read.js. That test would switch a streams2 stream into old-mode, but with streams3, you hit
s.pause()
and it's right back where it was.The other semantic change is that adding a
readable
event handler will not causereadable
to be emitted until nextTick. Otherwise, stuff like this is problematic:All other semantics should be identical to master. API should be identical.
Still todo: docs.
Review/feedback please: @jclulow @bnoordhuis @indutny @Raynos @tjfontaine