Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

docs(assert) call signature of doesNotThrow should be equivalent to thro... #6580

Closed
wants to merge 1 commit into from

Conversation

basarat
Copy link

@basarat basarat commented Nov 24, 2013

...ws.

The body is identical:

assert.throws = function(block, /*optional*/error, /*optional*/message) {
  _throws.apply(this, [true].concat(pSlice.call(arguments)));
};

// EXTENSION! This is annoying to write outside this module.
assert.doesNotThrow = function(block, /*optional*/error, /*optional*/message) {
  _throws.apply(this, [false].concat(pSlice.call(arguments)));
};

…hrows.

The body is identical:
```
assert.throws = function(block, /*optional*/error, /*optional*/message) {
  _throws.apply(this, [true].concat(pSlice.call(arguments)));
};

// EXTENSION! This is annoying to write outside this module.
assert.doesNotThrow = function(block, /*optional*/error, /*optional*/message) {
  _throws.apply(this, [false].concat(pSlice.call(arguments)));
};
```
@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit basarat/node@1399694 has the following error(s):

  • First line of commit message must be no longer than 50 characters
  • Commit message must indicate the subsystem this commit changes
  • Commit message line too long: 4
  • Commit message line too long: 9

The following commiters were not found in the CLA:

  • Basarat Ali Syed

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@trevnorris
Copy link

@isaacs comment on the patch?

the commit message would have to be cleaned up for sure.

@jasnell
Copy link
Member

jasnell commented Aug 16, 2015

This PR is not going to be able to land. I opened an issue on nodejs/node to track the issue. Closing here.

@jasnell jasnell closed this Aug 16, 2015
@basarat basarat deleted the patch-1 branch August 16, 2015 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants