Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

add support for SPF records to DNS resolver #7699

Closed
wants to merge 1 commit into from
Closed

add support for SPF records to DNS resolver #7699

wants to merge 1 commit into from

Conversation

jons
Copy link

@jons jons commented May 29, 2014

tested on v0.10.28 release. see: https://tools.ietf.org/html/rfc4408#section-3.1.1

@bnoordhuis
Copy link
Member

Your pull request is made against master but it looks like v0.10 code and new features don't usually get accepted into the stable branch (i.e. v0.10). I would recommend updating your code so it compiles with V8 3.25.

Another thing is the commit log, it doesn't adhere to the style guide. See CONTRIBUTING.md for an example.

@indutny
Copy link
Member

indutny commented May 30, 2014

@jons sorry, but as @bnoordhuis said, landing new features in v0.10 branch is against our policy. Would you mind rebasing it onto a master branch?

@jons
Copy link
Author

jons commented May 30, 2014

i didn't bother with setting the upstream track, but CONTRIBUTING.md demonstrates using "-t origin/v0.10" -- is this correct?

i'll fix the commit log. i assume the correct subsystem name is "dns" ?

i was not offering a backport i was simply stating that i had tested it there, not master (but i will test it in master AND add/modify any existing unit tests for the next pull request).

@jons
Copy link
Author

jons commented May 30, 2014

i've also just learned that rfc 4408 was accepted to the standards track last month as 7208 so it wasn't even named correctly :)

@jons
Copy link
Author

jons commented Jun 2, 2014

closing this request to create a new one.

@jons jons closed this Jun 2, 2014
jBarz pushed a commit to ibmruntimes/node that referenced this pull request May 11, 2017
.eslintrc was renamed in nodejs#7699 to .eslintrc.yaml.

PR-URL: nodejs/node#12116
Refs: nodejs/node#7699
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
.eslintrc was renamed in nodejs#7699 to .eslintrc.yaml.

PR-URL: nodejs/node#12116
Refs: nodejs/node#7699
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants