This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
gyp: do not remove unused openssl syms on osx #8029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Increases the binary size by 400kb approximately :( |
|
Fixes stuff on linux too. |
Neilpang
pushed a commit
to Neilpang/node
that referenced
this pull request
Jul 31, 2014
PKCS7_sign() method doesn't work in addon modules linking to openssl.
|
Landed in 9f36c0d, let's see what will happen. |
|
Doesn't address Windows. See #4051. |
|
Yeah, I can't really fight on that field :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8026
@tjfontaine: I suggest landing it before next v0.10 release