This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
tests: do not hardcode service name in test-dns. #8121
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding http service name in test-dns, retrieve it from /etc/services. This is not ideal, but it's still better than hard-coding it.
I initially implemented it by reading from /etc/services asynchronously, but it lead to me writing line parsing code that seemed a bit overkill in this tiny utility module. I don't think it's worth it now, because we don't run tests concurrently. If you'd rather have me revert to this async behavior, I'll be happy to update the PR.
Tested on OS X, Windows, Ubuntu and SmartOS.
Fixes #8047.