Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

tests: do not hardcode service name in test-dns. #8121

Closed

Conversation

misterdjules
Copy link

Instead of hard-coding http service name in test-dns, retrieve it from /etc/services. This is not ideal, but it's still better than hard-coding it.

I initially implemented it by reading from /etc/services asynchronously, but it lead to me writing line parsing code that seemed a bit overkill in this tiny utility module. I don't think it's worth it now, because we don't run tests concurrently. If you'd rather have me revert to this async behavior, I'll be happy to update the PR.

Tested on OS X, Windows, Ubuntu and SmartOS.

Fixes #8047.

Instead of hard-coding http service name in test-dns, retrieve it from
/etc/services. This is not ideal, but it's still better than hard-coding
it.

Fixes nodejs#8047.
@trevnorris
Copy link

@tjfontaine thoughts?

@tjfontaine
Copy link

Landed in f5f5bd7

@tjfontaine tjfontaine closed this Aug 14, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants