Build fixes from MSYS2/MinGW-w64 #8294
Conversation
|
Could anyone take a look at this? |
|
One issue about INTPTR. The rest LGTM, though someone who is more familiar might want to review the makefile changes msys2-contrib@58c2446 |
They both take 4 arguments, not 2.
It takes a single argument.
mingwandroid
force-pushed
the
master
branch
from
ab5d449
to
36638f6
Compare
|
@mingwandroid I luv ya!!! |
|
@mingwandroid trying, but building |
|
Good point on $(EXEEXT). I also need to check that one on Linux and OSX. |
|
@refack This isn't all the patches needed for MSYS2/MinGW-w64, there'll be follow up pull requests once I get these ones in and the next ones into a pushable state. The (current) full set can be found at: https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-nodejs As for openssl, we use pacman from Arch Linux, so binary dependencies for openssl are used, though you can compile any dependency yourself using makepkg/makepkg-mingw. HOWTO build node from source for and on MSYS2/MinGW-w64:Install MSYS2 from http://msys2.github.io from Run the MSYS2 shell (from the installer or msys2_shell.bat)Update packages database:pacman -Sy Install git, patch and MinGW-w64 native compilers:pacman -S git patch mingw-w64-i686-toolchain mingw-w64-x86_64-toolchain Clone MSYS2's MinGW-w64 PKGBUILDs repository:git clone https://github.com/Alexpux/MINGW-packages Build the packages.makepkg-mingw -sLf Install them:pacman -U mingw-w64-*.xz Use:/mingw64/bin/node or:/mingw64/bin/npm (you can avoid needing to specify the full paths if you run mingw32_shell.bat or mingw64_shell.bat) |
mingwandroid
force-pushed
the
master
branch
from
36638f6
to
d1522bb
Compare
mingwandroid
force-pushed
the
master
branch
from
d1522bb
to
0ece2fe
Compare
|
@mingwandroid I'm trying to build |
| # Determine EXEEXT | ||
| EXEEXT=$(shell $(PYTHON) -c "import sysconfig; print(sysconfig.get_config_var('EXE'))") | ||
|
|
||
| NODE ?= ./node$(EXEEXT) |
There was a problem hiding this comment.
Want to double check. Will EXEEXT contain the dot (e.g. .exe, not just exe)?
|
It will contain the dot yes. |
|
@tjfontaine @indutny Mind taking a look at the build stuff? LGTM but want your input as well. |
|
Any more on this guys? |
|
LGTM |
|
Thank you, landed in node-forward/node@6f94b3d, node-forward/node@eccb101 |
|
Many thanks. |
|
Out of interest, should my merge requests be done to node-forward/node in future? |
|
Closing since it appears this already landed in io.js. We'll pick it up there. cc @joyent/node-tsc |
I work on the MSYS2 project and node.js is one of our packages. I'd like upstream my patches and would like to have a discussion about this set of changes first.