Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

configure: add --openssl-no-asm flag #8304

Closed
wants to merge 1 commit into from
Closed

configure: add --openssl-no-asm flag #8304

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Sep 2, 2014

@tjfontaine tjfontaine added in progress and removed pr labels Sep 2, 2014
@indutny indutny mentioned this pull request Sep 2, 2014
Closed
@trevnorris
Copy link

@indutny Since @lutzbickhardt confirmed this doesn't fix the bug do we still want to add this build option?

@indutny
Copy link
Member Author

indutny commented Sep 3, 2014

@trevnorris yeah, why not. I always wanted to be able to configure this.

@trevnorris
Copy link

Cool. Then LGTM.

@lutzbickhardt
Copy link

Hi,

repeated with 0.10.28 (without the --openssl... option) -> seg fault !!!

repeated with 0.8.29-pre (without the --openssl... option) -> fine

any ideas??

Cordialement

Lutz BICKHARDT
lutz@bickhardt.fr

@indutny
Copy link
Member Author

indutny commented Sep 3, 2014

@lutzbickhardt I have no idea, does any other v0.10.x work for you?

@lutzbickhardt
Copy link

traced it back to:

0.9.10: ok

0.9.11: seg fault !!!

Cordialement

@indutny
Copy link
Member Author

indutny commented Sep 3, 2014

Bad news, this is probably a v8 upgrade:

 V8: Upgrade to 3.15.11.15

@indutny
Copy link
Member Author

indutny commented Sep 3, 2014

Landed in 627c1a9, thank you!

@indutny indutny closed this Sep 3, 2014
@indutny indutny deleted the feature/openssl-no-asm branch September 3, 2014 13:36
@lutzbickhardt
Copy link

?

what can we do?

anyway the good news is that 0.10.32-pre with the --openssl-no-asm? option does not segfault on the raspi (just tested it)

@indutny
Copy link
Member Author

indutny commented Sep 4, 2014

@lutzbickhardt I have no idea, because I don't have such computer at hand. In fact even without --openssl-no-asm it appears to be working fine on my rpi.

gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Oct 12, 2016
@madarche @Fishrock123
doc: add added: info for crypto.timingSafeEqual()
e7c0f34 
crypto.timingSafeEqual() has been added in v6.6.0 cf. nodejs#8304

This commit adds the metadata that will display
"Added in: v6.6.0" and that can later be checked on
https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b

PR-URL: nodejs/node#8796
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
kaiquewdev pushed a commit to kaiquewdev/node that referenced this pull request Nov 26, 2016
@madarche @jasnell
doc: add added: info for crypto.timingSafeEqual()
bb78f65 
crypto.timingSafeEqual() has been added in v6.6.0 cf. nodejs#8304

This commit adds the metadata that will display
"Added in: v6.6.0" and that can later be checked on
https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b

PR-URL: nodejs/node#8796
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress pr v0.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@indutny @trevnorris @lutzbickhardt @tjfontaine @Nodejs-Jenkins