This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
child_process: add safety checks on stdio accesses #8779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a child process is spawned, there is no guarantee that the stdio streams will be created. This commit adds checks before attempting to access the streams.
|
@cjihrig ... any updates on this one? |
|
This never got reviewed, but is something that I'm still interested in PR'ing into nodejs/node. |
|
Closing, as this has been opened on nodejs/node. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a child process is spawned, there is no guarantee that the stdio streams will be created. This commit adds checks before attempting to access the streams.