This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Remove the option of building against a shared cares #8786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..since the bundled cares differs from upstream.
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 3, 2014
Bundled cares differs from upstream which will result in a compilation error when trying to used a shared cares. PR-URL: nodejs/node-v0.x-archive#8786 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 3, 2014
Bundled cares differs from upstream which will result in a compilation error when trying to used a shared cares. Fixes: nodejs/node-v0.x-archive#8786 PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 4, 2014
Bundled cares differs from upstream which will result in a compilation error when trying to used a shared cares. Fixes: nodejs/node-v0.x-archive#8786 PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 4, 2014
Bundled cares differs from upstream which will result in a compilation error when trying to used a shared cares. Fixes: nodejs/node-v0.x-archive#8786 PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 4, 2014
Bundled cares differs from upstream which will result in a compilation error when trying to used a shared cares. Fixes: nodejs/node-v0.x-archive#8786 PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 4, 2014
Bundled cares differs from upstream which will result in a compilation error when trying to used a shared cares. Fixes: nodejs/node-v0.x-archive#8786 PR-URL: #38 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
cc @tjfontaine |
|
This is not something that would land at this point. If it's something that's worth exploring further, a new PR against nodejs/node would be required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..since it won't build anyway. Should be reverted if/when upstream adapts a similar featureset.
Ping @indutny