Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

process: removeAllListeners failing for signals #8953

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,8 @@
var addListener = process.addListener;
var removeListener = process.removeListener;

process.on('removeListener', function() {});

function isSignal(event) {
return event.slice(0, 3) === 'SIG' &&
startup.lazyConstants().hasOwnProperty(event);
Expand Down
41 changes: 41 additions & 0 deletions test/simple/process-remove-all-signal-listeners.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
if (process.platform === 'win32') {
// Win32 doesn't have signals, just a kindof emulation, insufficient
// for this test to apply.
return;
}

var assert = require('assert');
var spawn = require('child_process').spawn;
var ok;

if (!process.env.DOTEST) {
// We are the master, fork a child so we can verify it exits with correct
// status.
process.env.DOTEST = 'y';
var child = spawn(process.execPath, [__filename]);

child.once('exit', function(code, signal) {
assert.equal(signal, 'SIGINT');
ok = true;
});

process.on('exit', function(code) {
if (code === 0)
assert(ok);
});

return;
}

process.on('SIGINT', function() {
// Remove all handlers and kill ourselves. We should terminate by SIGINT
// now that we have no handlers.
process.removeAllListeners('SIGINT');
process.kill(process.pid, 'SIGINT');
});

// Signal handlers aren't sufficient to keep node alive, so resume stdin
process.stdin.resume();

// Demonstrate that signals are being handled
process.kill(process.pid, 'SIGINT');