This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix issue 9070 #9071
Closed
Fix issue 9070 #9071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added license info from: http://source.icu-project.org/repos/icu/icu/trunk/license.html All text pasted. Long lines wrapped. (original is HTML.) Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
On non-windows supported platforms, fs.access(readOnlyFile, W_OK, ...) is expected to fail, but always succeeds if node runs as the super user, which is often the case for tests running on our continuous integration platform. This change makes the test try to change its process user id to nobody on non-windows platforms so that the above mentioned test can pass and still perform the actual desired test. If changing the process user id to a nobody is not possible, then the test checks that fs.access(readOnlyFile, W_OK, ...) actually succeeds. Fixes #9033. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
Since the current environment is in scope use ThrowError on that, instead of having to lookup the Environment again. Added benefit, lint the source code. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
Make this test less prone to race conditions by using synchronous interprocess communication instead of a timer to determine when the child process is ready to receive messages from its parent. Also, remove a superfluous timer since the tests suite already makes tests time out after a while. Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
The message argument is optional for both assert() and assert.ok(). This commit makes message optional for assert(). PR-URL: #9003 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* v8: Upgrade to 3.28.73 * uv: Upgrade to 1.0.2 * npm: Upgrade to v2.1.6 * uv: float patch to revert tty breakage (Trevor Norris) * v8: re-implement debugger-agent (Fedor Indutny) * v8: apply floating irhydra patch (Fedor Indutny) * v8: fix postmortem-metadata generator (Refael Ackermann) * debugger: fix unhandled error in setBreakpoint (Miroslav Bajtoš) * async-wrap: add event hooks (Trevor Norris) * async-wrap: expose async-wrap as binding (Trevor Norris) * buffer, doc: misc. fix and cleanup (Trevor Norris) * buffer: add generic functions for (u)int ops (Yazhong Liu) * buffer: fix and cleanup fill() (Trevor Norris) * buffer: mv floating point read/write checks to JS (Trevor Norris) * build, i18n: improve Intl build, add "--with-intl" (Steven R. Loomis) * build: add small-icu support for binary packages (Julien Gilli) * build: do not generate support for libuv's probes (Julien Gilli) * build: i18n: add icu config options (Steven R. Loomis) * build: i18n: support little-endian machines (Steven Loomis) * build: vcbuild fix "The input line is too long." (Alexis Campailla) * child_process: improve spawn() argument handling (cjihrig) * cluster: avoid race enabling debugger in worker (Timothy J Fontaine) * cluster: cluster.disconnect() should check status (Sam Roberts) * cluster: do not signal children in debug mode (Fedor Indutny) * cluster: don't assert if worker has no handles (Sam Roberts) * core: fix usage of uv_cwd (Saúl Ibarra Corretgé) * core: replace uv_fs_readdir with uv_fs_scandir (Saúl Ibarra Corretgé) * crypto: createDiffieHellman throw for bad args (Trevor Norris) * crypto: lower RSS usage for TLSCallbacks (Fedor Indutny) * crypto: store thread id as pointer-sized (Alexis Campailla) * dns: propagate domain for c-ares methods (Chris Dickinson) * fs: fix symlink error message (Vladimir Kurchatkin) * http: Improve _addHeaderLines method (Jackson Tian) * http: cleanup setHeader() (Trevor Norris) * http: rename flush to flushHeaders (Timothy J Fontaine) * lib,src: fix spawnSync ignoring its 'env' option (Juanjo) * modules: adding load linked modules feature (Thorsten Lorenz) * net: Make server.connections un-enumerable (Patrick Mooney) * net: add pauseOnConnect option to createServer() (cjihrig) * net: make connect() input validation synchronous (cjihrig) * node: avoid automatic microtask runs (Vladimir Kurchatkin) * node: fix throws before timer module is loaded (Trevor Norris) * openssl: fix keypress requirement in apps on win32 (Fedor Indutny) * path: added parse() and format() functions (Rory Bradford) * path: allow calling platform specific methods (Timothy J Fontaine) * path: don't lower-cases drive letters (Bert Belder) * path: refactor normalizeArray() (Nathan Woltman) * process: pid can be a string in process.kill() (Sam Roberts) * readline: fix performance issue when large line (Jicheng Li) * readline: should not require an output stream. (Julien Gilli) * smalloc: check if obj has external data (Vladimir Kurchatkin) * smalloc: don't allow to dispose typed arrays (Vladimir Kurchatkin) * smalloc: fix bad assert for zero length data (Trevor Norris) * smalloc: fix copyOnto optimization (Vladimir Kurchatkin) * src: all wrap's now use actual FunctionTemplate (Trevor Norris) * src: fix VC++ warning C4244 (Rasmus Christian Pedersen) * src: remove Async Listener (Trevor Norris) * stream: switch _writableState.buffer to queue (Chris Dickinson) * streams: make setDefaultEncoding() throw (Brian White) * streams: set default encoding for writable streams (Johnny Ray) * tls: remove tls.createSecurePair code deprecation (Jackson Tian) * tls_wrap: ignore ZERO_RETURN after close_notify (Fedor Indutny) * url: change hostname regex to negate invalid chars (Jonathan Johnson) * url: fixed encoding for slash switching emulation. (Evan Rutledge Borden) * url: improve parsing speed (CGavrila) * url: make query() consistent (Gabriel Wicke) * url: support `path` for url.format (Yazhong Liu) * util: add es6 Symbol support for `util.inspect` (gyson)
A !query was inserted into an if statement that was breaking the url.format function and removing the query variables.
|
The corresponding issue, #9070, is exhibiting expected behavior -- |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A !query was inserted into an if statement that was breaking the
url.format function and removing the query variables.