This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Revert "url: support path for url.format"
#9109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d312b6d. d312b6d introduced some confusion in the existing API of url.format and url.parse. The way the 'path' property overrides other properties in url.format's input is too confusing for existing users compared to the issues it fixes. Fixes such as nodejs#9081 have been proposed, but they do not make the API less confusing. Instead, this change just reverts the original breaking change so that it gives us more time after v0.12.0 is released to come up with a better API for url.format, url.parse and other related APIs in the v0.13 development branch. Fixes nodejs#9070. Conflicts: doc/api/url.markdown
misterdjules
force-pushed
the
fix-issue-9070
branch
from
295c211
to
fbb1151
Compare
|
@chrisdickinson @cjihrig @trevnorris @tjfontaine @jasnell As discussed recently, please let me know what you think! |
|
Also, all tests pass on UNICes and on Windows. The tests haven't run yet on Windows 64 bits, but I don't expect any issue. I'll make sure they all pass on that target too though. |
|
LGTM |
|
Ok, tests pass on Windows too. Landing asap, thanks! |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jan 29, 2015
This reverts commit d312b6d. d312b6d introduced some confusion in the existing API of url.format and url.parse. The way the 'path' property overrides other properties in url.format's input is too confusing for existing users compared to the issues it fixes. Fixes such as nodejs#9081 have been proposed, but they do not make the API less confusing. Instead, this change just reverts the original breaking change so that it gives us more time after v0.12.0 is released to come up with a better API for url.format, url.parse and other related APIs in the v0.13 development branch. Fixes nodejs#9070. Conflicts: doc/api/url.markdown PR: nodejs#9109 PR-URL: nodejs#9109 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jan 29, 2015
This reverts commit d312b6d. d312b6d introduced some confusion in the existing API of url.format and url.parse. The way the 'path' property overrides other properties in url.format's input is too confusing for existing users compared to the issues it fixes. Fixes such as nodejs#9081 have been proposed, but they do not make the API less confusing. Instead, this change just reverts the original breaking change so that it gives us more time after v0.12.0 is released to come up with a better API for url.format, url.parse and other related APIs in the v0.13 development branch. Fixes nodejs#9070. Conflicts: doc/api/url.markdown PR: nodejs#9109 PR-URL: nodejs#9109 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
|
Landed in 3b392d3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d312b6d.
d312b6d introduced some confusion in
the existing API of url.format and url.parse.
The way the 'path' property overrides other properties in url.format's
input is too confusing for existing users compared to the issues it
fixes.
Fixes such as #9081 have been
proposed, but they do not make the API less confusing.
Instead, this change just reverts the original breaking change so that
it gives us more time after v0.12.0 is released to come up with a better
API for url.format, url.parse and other related APIs in the v0.13
development branch.
Fixes #9070.
Conflicts:
doc/api/url.markdown