This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
watchdog: fix timeout for early polling return #9410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from running the loop with UV_RUN_ONCE to UV_RUN_DEFAULT, because it's possible that the poll returns earlier than expected and thus the timer is not run on a single interation. The loop is not stopped either from the timer callback or from the async handle's. PR-URL: nodejs/node#622 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
|
LGTM. |
|
Also, please add this to the appropriate milestone (as well as the appropriate issue). This will allow anybody else looking at the issues/PRs in that milestone to also find it an review it, and will communicate in which release we want this to be merged. Currently we have two 0.12.x milestones, 0.12.1 and 0.12.2. If we want to integrate this fix asap and thus have people review it asap, let's add it to 0.12.1, otherwise let's add it to 0.12.2. Even if it's merged quickly, sometimes it's handy to be able to look back to what had been done for a particular release on GitHub. Thank you! |
mhdawson
pushed a commit
that referenced
this pull request
Mar 23, 2015
Switch from running the loop with UV_RUN_ONCE to UV_RUN_DEFAULT, because it's possible that the poll returns earlier than expected and thus the timer is not run on a single interation. The loop is not stopped either from the timer callback or from the async handle's. Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: #9410
|
Landed in 7e9d2f8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from running the loop with UV_RUN_ONCE to UV_RUN_DEFAULT, because
it's possible that the poll returns earlier than expected and thus the
timer is not run on a single interation.
The loop is not stopped either from the timer callback or from the async
handle's.
PR-URL: nodejs/node#622
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Rod Vagg rod@vagg.org