Skip to content

Commit

Permalink
deps: patch V8 to avoid duplicated zlib symbol
Browse files Browse the repository at this point in the history
PR-URL: nodejs/node#54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Sep 3, 2024
1 parent c93d185 commit 1b236a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.3',
'v8_embedder_string': '-node.4',

##### V8 defaults for Node.js #####

Expand Down
3 changes: 3 additions & 0 deletions deps/v8/third_party/zlib/chromeconf.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,5 +199,8 @@
/* Symbols added by cpu_features.c */
#define cpu_check_features Cr_z_cpu_check_features
#define x86_cpu_enable_sse2 Cr_z_x86_cpu_enable_sse2
#define x86_cpu_enable_avx512 Cr_z_x86_cpu_enable_avx512
#define riscv_cpu_enable_rvv Cr_z_riscv_cpu_enable_rvv
#define riscv_cpu_enable_vclmul Cr_z_riscv_cpu_enable_vclmul

#endif /* THIRD_PARTY_ZLIB_CHROMECONF_H_ */

0 comments on commit 1b236a9

Please sign in to comment.