Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 133
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 13.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
  • Loading branch information
nodejs-github-bot committed Dec 13, 2024
1 parent 314694a commit b9dde5d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 133, "runtime": "node", "variant": "v8_13.3", "versions": "24.0.0-pre" },
{ "modules": 132,"runtime": "electron", "variant": "electron", "versions": "34" },
{ "modules": 131,"runtime": "node", "variant": "v8_12.9", "versions": "23.0.0" },
{ "modules": 130,"runtime": "electron", "variant": "electron", "versions": "33" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
#if defined(NODE_EMBEDDER_MODULE_VERSION)
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION
#else
#define NODE_MODULE_VERSION 131
#define NODE_MODULE_VERSION 133
#endif

// The NAPI_VERSION supported by the runtime. This is the inclusive range of
Expand Down

0 comments on commit b9dde5d

Please sign in to comment.