-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error on Windows #235
Comments
@nodejs/platform-windows |
This is actually not specific to debug builds. |
I just created an upstream issue: https://bugs.chromium.org/p/v8/issues/detail?id=13093 |
Unfortunately this is still happening... https://github.com/nodejs/node-v8/runs/8087799918?check_suite_focus=true |
Bit of a long shot but does this help? diff --git a/src/wasm/function-body-decoder-impl.h b/src/wasm/function-body-decoder-impl.h
index f8ca69d8485..5ef0eed5aed 100644
--- a/src/wasm/function-body-decoder-impl.h
+++ b/src/wasm/function-body-decoder-impl.h
@@ -2136,7 +2136,7 @@ class WasmDecoder : public Decoder {
}
// TODO(clemensb): This is only used by the interpreter; move there.
- V8_EXPORT_PRIVATE std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
+ std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
WasmOpcode opcode = static_cast<WasmOpcode>(*pc);
// Handle "simple" opcodes with a fixed signature first.
const FunctionSig* sig = WasmOpcodes::Signature(opcode); WasmDecoder is a template class. Annotating members with |
@bnoordhuis looks good (arm64 build failed because of #240)! |
Nice. I'll open a V8 CL tomorrow. |
@bnoordhuis can you please post a link to the V8 CL here? |
Just a thought, but this might be related to nodejs build system layer (gyp). V8_EXPORT_PRIVATE is defined here following other macros:
Those macros are set in tools/v8_gypfiles/v8.gyp. The solution to remove |
@targos I can confirm this compilation error is not present when building v8 directly. I'd suggest a fix around nodejs build system with macros explained above. |
@pbo-linaro would you be able to identify exactly where the wrong macro is set? |
I'll try to look at it, but that would be better if someone who worked on gyp/gn layer tackles this. |
@targos: For now, how do you deal with custom patches that nodejs applies to v8? Are there kept somewhere? |
I keep them on the |
You can safely remove that V8_EXPORT_PRIVATE in src/wasm/function-body-decoder-impl.h. |
@targos After trying random stuff around node build system, I could not get something that was solving this issue. I suggest you keep a patch (on node side) removing that export for now. |
Will do, thanks a lot for investigating! |
https://ci.nodejs.org/job/node-compile-windows-debug/12735/nodes=win-vs2019/console
The text was updated successfully, but these errors were encountered: