Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New deprecations #46

Closed
targos opened this issue Mar 23, 2018 · 2 comments
Closed

New deprecations #46

targos opened this issue Mar 23, 2018 · 2 comments

Comments

@targos
Copy link
Member

targos commented Mar 23, 2018

These cannot be fixed on master:


../src/async_wrap.cc: In function ‘void node::LoadAsyncWrapperInfo(node::Environment*)’:
../src/async_wrap.cc:575:77: warning: ‘void v8::HeapProfiler::SetWrapperClassInfoProvider(uint16_t, v8::HeapProfiler::WrapperInfoCallback)’ is deprecated: Use SetBuildEmbedderGraphCallback to provide info about embedder nodes [-Wdeprecated-declarations]
       (NODE_ASYNC_ID_OFFSET + AsyncWrap::PROVIDER_ ## PROVIDER), WrapperInfo);
                                                                             ^
../src/async_wrap.h:37:3: note: in expansion of macro ‘V’
   V(NONE)                                                                     \
   ^
../src/async_wrap.h:89:3: note: in expansion of macro ‘NODE_ASYNC_NON_CRYPTO_PROVIDER_TYPES’
   NODE_ASYNC_NON_CRYPTO_PROVIDER_TYPES(V)                                     \
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/async_wrap.cc:576:3: note: in expansion of macro ‘NODE_ASYNC_PROVIDER_TYPES’
   NODE_ASYNC_PROVIDER_TYPES(V)
   ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../deps/v8/include/v8.h:26:0,
                 from ../src/node_persistent.h:6,
                 from ../src/base_object.h:27,
                 from ../src/async_wrap.h:27,
                 from ../src/async_wrap-inl.h:27,
                 from ../src/async_wrap.cc:22:
../deps/v8/include/v8-profiler.h:882:12: note: declared here
       void SetWrapperClassInfoProvider(uint16_t class_id,
            ^
../deps/v8/include/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../src/env.cc: In lambda function:
../src/env.cc:244:56: warning: ‘void v8::CpuProfiler::SetIdle(bool)’ is deprecated: Use Isolate::SetIdle(bool) instead. [-Wdeprecated-declarations]
     env->isolate_data()->GetCpuProfiler()->SetIdle(true);
                                                        ^
In file included from ../deps/v8/include/v8.h:26:0,
                 from ../src/node.h:63,
                 from ../src/node_internals.h:27,
                 from ../src/env.cc:1:
../deps/v8/include/v8-profiler.h:339:22: note: declared here
                 void SetIdle(bool is_idle));
                      ^
../deps/v8/include/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
../src/env.cc: In lambda function:
../src/env.cc:249:57: warning: ‘void v8::CpuProfiler::SetIdle(bool)’ is deprecated: Use Isolate::SetIdle(bool) instead. [-Wdeprecated-declarations]
     env->isolate_data()->GetCpuProfiler()->SetIdle(false);
                                                         ^
In file included from ../deps/v8/include/v8.h:26:0,
                 from ../src/node.h:63,
                 from ../src/node_internals.h:27,
                 from ../src/env.cc:1:
../deps/v8/include/v8-profiler.h:339:22: note: declared here
                 void SetIdle(bool is_idle));
                      ^
../deps/v8/include/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
targos added a commit to nodejs/node that referenced this issue Mar 23, 2018
@targos
Copy link
Member Author

targos commented Mar 23, 2018

Second one fixed in nodejs/node@82df09f

Edit: Should also revert nodejs/node@f02b74d

nodejs-ci pushed a commit that referenced this issue Mar 24, 2018
nodejs-ci pushed a commit that referenced this issue Mar 25, 2018
nodejs-ci pushed a commit that referenced this issue Mar 26, 2018
targos added a commit to nodejs/node that referenced this issue Mar 28, 2018
nodejs-ci pushed a commit that referenced this issue Mar 29, 2018
nodejs-ci pushed a commit that referenced this issue Mar 30, 2018
nodejs-ci pushed a commit that referenced this issue Mar 31, 2018
targos added a commit to nodejs/node that referenced this issue Apr 3, 2018
nodejs-ci pushed a commit that referenced this issue Apr 3, 2018
nodejs-ci pushed a commit that referenced this issue Apr 4, 2018
nodejs-ci pushed a commit that referenced this issue Apr 4, 2018
targos added a commit to nodejs/node that referenced this issue Apr 5, 2018
nodejs-ci pushed a commit that referenced this issue Apr 5, 2018
targos added a commit to nodejs/node that referenced this issue Apr 7, 2018
nodejs-ci pushed a commit that referenced this issue Apr 7, 2018
nodejs-ci pushed a commit that referenced this issue Apr 8, 2018
nodejs-ci pushed a commit that referenced this issue Apr 9, 2018
targos added a commit to nodejs/node that referenced this issue Apr 10, 2018
nodejs-ci pushed a commit that referenced this issue Apr 11, 2018
targos added a commit to nodejs/node that referenced this issue Apr 12, 2018
nodejs-ci pushed a commit that referenced this issue Apr 13, 2018
nodejs-ci pushed a commit that referenced this issue Apr 14, 2018
nodejs-ci pushed a commit that referenced this issue Apr 15, 2018
targos added a commit to nodejs/node that referenced this issue Apr 19, 2018
nodejs-ci pushed a commit that referenced this issue May 14, 2018
nodejs-ci pushed a commit that referenced this issue May 15, 2018
nodejs-ci pushed a commit that referenced this issue May 16, 2018
targos added a commit to nodejs/node that referenced this issue May 18, 2018
nodejs-ci pushed a commit that referenced this issue May 18, 2018
targos added a commit to nodejs/node that referenced this issue May 22, 2018
nodejs-ci pushed a commit that referenced this issue May 22, 2018
nodejs-ci pushed a commit that referenced this issue May 23, 2018
targos added a commit to nodejs/node that referenced this issue May 24, 2018
nodejs-ci pushed a commit that referenced this issue May 25, 2018
nodejs-ci pushed a commit that referenced this issue May 26, 2018
targos added a commit to nodejs/node that referenced this issue May 29, 2018
nodejs-ci pushed a commit that referenced this issue May 29, 2018
targos added a commit to targos/node that referenced this issue May 31, 2018
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2018
Refs: nodejs/node-v8#46

PR-URL: #19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2018
Refs: nodejs/node-v8#46

PR-URL: #19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
hferreiro pushed a commit to brave/node that referenced this issue Jul 18, 2018
Refs: nodejs/node-v8#46

PR-URL: nodejs/node#19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
(cherry picked from commit fbe6b85)
nodejs-ci pushed a commit that referenced this issue Aug 24, 2019
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [#222](npm/cli#222)
  [#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `hosted-git-info@2.8.2`
    * [#46](npm/hosted-git-info#46)
      [#43](npm/hosted-git-info#43)
      [#47](npm/hosted-git-info#47)
      [#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))

PR-URL: nodejs/node#29023
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant