Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on SmartOS (6.1) #8

Closed
targos opened this issue Jun 23, 2017 · 8 comments
Closed

Build failure on SmartOS (6.1) #8

targos opened this issue Jun 23, 2017 · 8 comments

Comments

@targos
Copy link
Member

targos commented Jun 23, 2017

CI run: https://ci.nodejs.org/job/node-test-commit-smartos/9806/nodes=smartos15-64/console

  LD_LIBRARY_PATH=/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/lib.host:/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src; dtrace -G -xnolibs -s src/node_provider.d "/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace.o" -o "/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_provider.o"
  touch /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node_dtrace_provider.stamp
dtrace: failed to compile script src/v8ustack.d: line 377: failed to resolve V8DBG_CLASS_SHAREDFUNCTIONINFO__NAME__OBJECT: Unknown variable name
node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o' failed
make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos15-64/out/Release/obj.target/node/src/node_dtrace_ustack.o] Error 1

/cc @nodejs/platform-smartos

@geek
Copy link
Member

geek commented Jun 23, 2017

@targos I'll take a look today

@misterdjules
Copy link

@targos You can use the following patch to get passed the compilation error: https://gist.github.com/misterdjules/f0bc7b42de7f9ee72e9535f0ce361ea0. The patch itself is not correct though, in the sense that the function position and function names outputted by the DTrace ustack helper are not correct, but I would think it's fine for now. Is that a correct assumption?

targos added a commit to nodejs/node that referenced this issue Jun 26, 2017
targos added a commit that referenced this issue Jun 26, 2017
nodejs-ci pushed a commit that referenced this issue Jun 26, 2017
@targos
Copy link
Member Author

targos commented Jun 26, 2017

@misterdjules It does not seem quite correct.
I applied your patch: 0bf3f91 and now the error is: dtrace: failed to compile script src/v8ustack.d: line 458: failed to resolve V8DBG_SHAREDFUNCTION_FUNCTION_TOKEN_POSITION: Unknown variable name

CI run: https://ci.nodejs.org/job/node-test-commit-smartos/9836/nodes=smartos15-64/console

@misterdjules
Copy link

@targos

My apologies, I had forgotten to update the gist with all my local changes. I did so now, and using that gist should now allow you to work around the build errors.

When is that version of V8 scheduled to be merged in master?

targos added a commit to nodejs/node that referenced this issue Jun 27, 2017
nodejs-ci pushed a commit that referenced this issue Jun 27, 2017
nodejs-ci pushed a commit that referenced this issue Jun 27, 2017
@targos
Copy link
Member Author

targos commented Jun 27, 2017

@misterdjules Thank you. V8 6.1 should be merged in early September.

targos added a commit to nodejs/node that referenced this issue Jun 28, 2017
nodejs-ci pushed a commit that referenced this issue Jun 28, 2017
nodejs-ci pushed a commit that referenced this issue Jun 29, 2017
nodejs-ci pushed a commit that referenced this issue Jun 30, 2017
targos added a commit to nodejs/node that referenced this issue Jul 3, 2017
nodejs-ci pushed a commit that referenced this issue Jul 3, 2017
nodejs-ci pushed a commit that referenced this issue Jul 4, 2017
nodejs-ci pushed a commit that referenced this issue Jul 5, 2017
nodejs-ci pushed a commit that referenced this issue Jul 6, 2017
nodejs-ci pushed a commit that referenced this issue Jul 7, 2017
nodejs-ci pushed a commit that referenced this issue Jul 8, 2017
nodejs-ci pushed a commit that referenced this issue Jul 9, 2017
nodejs-ci pushed a commit that referenced this issue Jul 10, 2017
nodejs-ci pushed a commit that referenced this issue Jul 11, 2017
nodejs-ci pushed a commit that referenced this issue Jul 12, 2017
targos added a commit to nodejs/node that referenced this issue Jul 13, 2017
nodejs-ci pushed a commit that referenced this issue Aug 31, 2017
nodejs-ci pushed a commit that referenced this issue Sep 1, 2017
nodejs-ci pushed a commit that referenced this issue Sep 2, 2017
nodejs-ci pushed a commit that referenced this issue Sep 3, 2017
nodejs-ci pushed a commit that referenced this issue Sep 4, 2017
nodejs-ci pushed a commit that referenced this issue Sep 5, 2017
nodejs-ci pushed a commit that referenced this issue Sep 6, 2017
nodejs-ci pushed a commit that referenced this issue Sep 6, 2017
nodejs-ci pushed a commit that referenced this issue Sep 7, 2017
nodejs-ci pushed a commit that referenced this issue Sep 8, 2017
nodejs-ci pushed a commit that referenced this issue Sep 9, 2017
nodejs-ci pushed a commit that referenced this issue Sep 10, 2017
nodejs-ci pushed a commit that referenced this issue Sep 11, 2017
nodejs-ci pushed a commit that referenced this issue Sep 12, 2017
@targos targos closed this as completed Sep 12, 2017
targos added a commit to targos/node that referenced this issue Sep 12, 2017
nodejs-ci pushed a commit that referenced this issue Sep 13, 2017
addaleax pushed a commit to nodejs/node that referenced this issue Sep 13, 2017
Refs: nodejs/node-v8#8
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this issue Sep 13, 2017
Refs: nodejs/node-v8#8
PR-URL: nodejs#14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs-ci pushed a commit that referenced this issue Sep 14, 2017
targos added a commit to targos/node that referenced this issue Sep 14, 2017
Refs: nodejs/node-v8#8
PR-URL: nodejs#14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit to targos/node that referenced this issue Sep 21, 2017
Refs: nodejs/node-v8#8
PR-URL: nodejs#14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Sep 28, 2017
Refs: nodejs/node-v8#8
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Sep 29, 2017
Refs: nodejs/node-v8#8
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Oct 3, 2017
Refs: nodejs/node-v8#8
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants