-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on SmartOS (6.1) #8
Comments
@targos I'll take a look today |
@targos You can use the following patch to get passed the compilation error: https://gist.github.com/misterdjules/f0bc7b42de7f9ee72e9535f0ce361ea0. The patch itself is not correct though, in the sense that the function position and function names outputted by the DTrace ustack helper are not correct, but I would think it's fine for now. Is that a correct assumption? |
@misterdjules It does not seem quite correct. CI run: https://ci.nodejs.org/job/node-test-commit-smartos/9836/nodes=smartos15-64/console |
My apologies, I had forgotten to update the gist with all my local changes. I did so now, and using that gist should now allow you to work around the build errors. When is that version of V8 scheduled to be merged in master? |
@misterdjules Thank you. V8 6.1 should be merged in early September. |
Refs: nodejs/node-v8#8 PR-URL: #14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8 PR-URL: nodejs#14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8 PR-URL: nodejs#14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8 PR-URL: nodejs#14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8 Backport-PR-URL: #15393 PR-URL: #14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8 Backport-PR-URL: #15393 PR-URL: #14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8 Backport-PR-URL: #15393 PR-URL: #14730 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
CI run: https://ci.nodejs.org/job/node-test-commit-smartos/9806/nodes=smartos15-64/console
/cc @nodejs/platform-smartos
The text was updated successfully, but these errors were encountered: