Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-zlib-unused-weak on V8 8.2 #152

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a73b80e
doc: update README for node-v8 repository
nodejs-ci Mar 13, 2020
68f68ca
deps: update V8 to 8.2.0
nodejs-ci Mar 13, 2020
8988594
build: reset embedder string to "-node.0"
nodejs-ci Mar 13, 2020
d7f1a9e
tools: update V8 gypfiles for 8.1
mmarchini Mar 5, 2020
af577fb
deps: update V8 dtrace & postmortem metadata
cjihrig Oct 15, 2019
1d0b71d
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
350bc5c
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
7bcd7e8
deps: V8: patch register-arm64.h
refack May 22, 2019
ebbc01c
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
459830e
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
52eb5b2
Revert "assert: fix line number calculation after V8 upgrade"
targos Dec 6, 2019
bd8c66e
deps: bump minimum icu version to 65
targos Jan 6, 2020
f82a90d
deps: V8: cherry-pick 1e36e21acc40
mmarchini Mar 6, 2020
5ea71eb
deps: V8: cherry-pick 931bdbd76f5b
mmarchini Mar 11, 2020
422ec9e
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
2277d0c
deps: patch V8 to run on Xcode 8
mmarchini Mar 10, 2020
18eee7e
src: stop overriding deprecated V8 methods
backes Dec 2, 2019
4c1112c
src: remove use of deprecated Symbol::Name()
cjihrig Dec 14, 2019
75aa9a8
src: avoid calling deprecated method
backes Feb 3, 2020
1ccc45b
src: remove deprecated wasm type check
backes Feb 6, 2020
f43d1f8
test: remove checks for deserializing wasm
mmarchini Mar 6, 2020
c0b0f8e
test: remove test
backes Feb 6, 2020
672dc3f
test: mark inspector tests as flaky
mmarchini Mar 4, 2020
dde6abf
src: migrate measureMemory to new v8 api
gengjiawen Mar 4, 2020
e6c9e7f
build: temporarily skip ASAN build
mmarchini Mar 11, 2020
8a65cea
tools: update V8 gypfiles
targos Feb 11, 2020
20260fc
tools: update v8 gypfiles
targos Feb 14, 2020
72639b6
tools: update v8 gypfiles
targos Feb 27, 2020
60bde39
Rename FinalizationGroup to FinalizationRegistry
syg Feb 24, 2020
452311e
deps: revert postmortem metadata floating patch
mmarchini Mar 8, 2020
9d85ab0
test: fix test-zlib-unused-weak on V8 8.2
mmarchini Mar 14, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .github/workflows/ASAN.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Build
# TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
# memory to build with debug and ASAN. Allow this build to fail until
# we figure out a workaround, or until we update to 8.2 (where build
# is passing).
continue-on-error: true
run: |
npx envinfo
./configure --debug --enable-asan --ninja && ninja -C out/Debug
Expand Down
606 changes: 9 additions & 597 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.30',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
3 changes: 3 additions & 0 deletions deps/v8/.git-blame-ignore-revs
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ e50b49a0e38b34e2b28e026f4d1c7e0da0c7bb1a

# Rewrite code base to use "." instead of "->" to access Object members.
878ccb33bd3cf0e6dc018ff8d15843f585ac07be

# Move test/mjsunit/regress-*.js => test/mjsunit/regress/
cb67be1a3842fcf6a0da18aee444e3b7ea789e04
6 changes: 6 additions & 0 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
.#*
.*.sw?
.ccls-cache
.clangd
.cpplint-cache
.cproject
.gclient_entries
Expand Down Expand Up @@ -99,6 +100,7 @@ compile_commands.json
gccauses
gcsuspects
gtags.files
jit-*.dump
node_modules
tags
turbo*.cfg
Expand All @@ -108,3 +110,7 @@ v8.ignition_dispatches_table.json

!/third_party/jinja2
!/third_party/markupsafe
!/third_party/zlib
/third_party/zlib/contrib/bench
/third_party/zlib/contrib/tests
/third_party/zlib/google/test
27 changes: 8 additions & 19 deletions deps/v8/.ycm_extra_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,27 +103,16 @@ def GetClangCommandFromNinjaForFilename(v8_root, filename):
# Header files can't be built. Instead, try to match a header file to its
# corresponding source file.
if filename.endswith('.h'):
alternates = ['.cc', '.cpp']
for alt_extension in alternates:
alt_name = filename[:-2] + alt_extension
if os.path.exists(alt_name):
filename = alt_name
base = filename[:-6] if filename.endswith('-inl.h') else filename[:-2]
for alternate in [base + e for e in ['.cc', '.cpp']]:
if os.path.exists(alternate):
filename = alternate
break
else:
if filename.endswith('-inl.h'):
for alt_extension in alternates:
alt_name = filename[:-6] + alt_extension
if os.path.exists(alt_name):
filename = alt_name
break;
else:
# If this is a standalone -inl.h file with no source, the best we can
# do is try to use the default flags.
return v8_flags
else:
# If this is a standalone .h file with no source, the best we can do is
# try to use the default flags.
return v8_flags
# If this is a standalone .h file with no source, we ask ninja for the
# compile flags of some generic cc file ('src/utils/utils.cc'). This
# should contain most/all of the interesting flags for other targets too.
filename = os.path.join(v8_root, 'src', 'utils', 'utils.cc')

sys.path.append(os.path.join(v8_root, 'tools', 'ninja'))
from ninja_output import GetNinjaOutputDirectory
Expand Down
9 changes: 9 additions & 0 deletions deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ Bert Belder <bertbelder@gmail.com>
Burcu Dogan <burcujdogan@gmail.com>
Caitlin Potter <caitpotter88@gmail.com>
Craig Schlenter <craig.schlenter@gmail.com>
Chengzhong Wu <legendecas@gmail.com>
Choongwoo Han <cwhan.tunz@gmail.com>
Chris Nardi <hichris123@gmail.com>
Christopher A. Taylor <chris@gameclosure.com>
Expand Down Expand Up @@ -95,12 +96,15 @@ Hannu Trey <hannu.trey@gmail.com>
Henrique Ferreiro <henrique.ferreiro@gmail.com>
Hirofumi Mako <mkhrfm@gmail.com>
Honggyu Kim <honggyu.kp@gmail.com>
Huáng Jùnliàng <jlhwung@gmail.com>
Iain Ireland <iireland@mozilla.com>
Ingvar Stepanyan <me@rreverser.com>
Ioseb Dzmanashvili <ioseb.dzmanashvili@gmail.com>
Isiah Meadows <impinball@gmail.com>
Jaime Bernardo <jaime@janeasystems.com>
Jan de Mooij <jandemooij@gmail.com>
Jan Krems <jan.krems@gmail.com>
Janusz Majnert <jmajnert@gmail.com>
Jay Freeman <saurik@saurik.com>
James Pike <g00gle@chilon.net>
James M Snell <jasnell@gmail.com>
Expand Down Expand Up @@ -149,6 +153,7 @@ Oliver Dunk <oliver@oliverdunk.com>
Paolo Giarrusso <p.giarrusso@gmail.com>
Patrick Gansterer <paroga@paroga.com>
Peng Fei <pfgenyun@gmail.com>
Peng-Yu Chen <pengyu@libstarrify.so>
Peter Rybin <peter.rybin@gmail.com>
Peter Varga <pvarga@inf.u-szeged.hu>
Peter Wong <peter.wm.wong@gmail.com>
Expand Down Expand Up @@ -193,10 +198,14 @@ Vladimir Krivosheev <develar@gmail.com>
Vladimir Shutoff <vovan@shutoff.ru>
Wenlu Wang <kingwenlu@gmail.com>
Wiktor Garbacz <wiktor.garbacz@gmail.com>
Wouter Vermeiren <wouter.vermeiren@essensium.com>
Xiaoyin Liu <xiaoyin.l@outlook.com>
Yannic Bonenberger <contact@yannic-bonenberger.com>
Yong Wang <ccyongwang@tencent.com>
Youfeng Hao <ajihyf@gmail.com>
Yu Yin <xwafish@gmail.com>
Zac Hansen <xaxxon@gmail.com>
Zhao Jiazhong <kyslie3100@gmail.com>
Zhongping Wang <kewpie.w.zp@gmail.com>
柳荣一 <admin@web-tinker.com>
Yanbo Li <lybvinci@gmail.com>
Loading