-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update postmortem metadata test #34
Conversation
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
It is necessary to enable more C++ features in order to build V8 6.4.
This commit renames V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT to V8DBG_CLASS_MAP__INSTANCE_TYPE__UINT16_T following upstream changes.
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of v8/v8@c00bb6d and v8/v8@cb46310 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da
Thanks! Quick check: https://ci.nodejs.org/job/node-test-commit-light/41/ |
There was a failure in the CI, but unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we document the changes, say, in the Wiki?
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of v8/v8@c00bb6d and v8/v8@cb46310 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Thanks, landed in nodejs/node@358a628 and nodejs/node@034b64b. |
I'm inclined to say no, simply because wikis get forgotten about and out of sync. I'm hoping to achieve the same thing in the commit log for the metadata test moving forward though. |
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of v8/v8@c00bb6d and v8/v8@cb46310 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of v8/v8@c00bb6d and v8/v8@cb46310 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of v8/v8@c00bb6d and v8/v8@cb46310 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: #34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> PR-URL: #18453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit updates the following postmortem metadata constants: - v8dbg_class_Map__inobject_properties_or_constructor_function_index__int - This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc - v8dbg_class_Map__instance_attributes__int - This is now v8dbg_class_Map__instance_type__uint16_t as of v8/v8@c00bb6d and v8/v8@cb46310 - v8dbg_class_Map__instance_size__int - This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc Refs: nodejs/node-v8#34 PR-URL: nodejs#17489 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#18453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit updates the following postmortem metadata constants:
v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of v8/v8@61bf2ccv8dbg_class_Map__instance_attributes__int
v8dbg_class_Map__instance_type__uint16_t
as of v8/v8@c00bb6d and v8/v8@cb46310v8dbg_class_Map__instance_size__int
v8dbg_class_Map__instance_size_in_words__char
as of v8/v8@61bf2ccv8dbg_bit_field3_dictionary_map_shift
v8dbg_bit_field3_is_dictionary_map_shift
as of v8/v8@7a159daFixes: #33
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)