Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update postmortem metadata test #34

Closed
wants to merge 9 commits into from

Conversation

cjihrig
Copy link

@cjihrig cjihrig commented Dec 19, 2017

This commit updates the following postmortem metadata constants:

  • v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
    • This is now v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char as of v8/v8@61bf2cc
  • v8dbg_class_Map__instance_attributes__int
  • v8dbg_class_Map__instance_size__int
    • This is now v8dbg_class_Map__instance_size_in_words__char as of v8/v8@61bf2cc
  • v8dbg_bit_field3_dictionary_map_shift
    • This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da

Fixes: #33

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-ci and others added 9 commits December 19, 2017 06:55
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 6.5.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
It is necessary to enable more C++ features in order to build V8 6.4.
This commit renames V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT
to V8DBG_CLASS_MAP__INSTANCE_TYPE__UINT16_T following upstream changes.
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc
- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da
@targos
Copy link
Member

targos commented Dec 19, 2017

Thanks! Quick check: https://ci.nodejs.org/job/node-test-commit-light/41/

@cjihrig
Copy link
Author

cjihrig commented Dec 19, 2017

There was a failure in the CI, but unrelated.

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document the changes, say, in the Wiki?

targos pushed a commit to nodejs/node that referenced this pull request Dec 20, 2017
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc

Refs: nodejs/node-v8#34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Dec 20, 2017
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: nodejs/node-v8#34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Dec 20, 2017

Thanks, landed in nodejs/node@358a628 and nodejs/node@034b64b.
I split the commit because some of the changes are needed for V8 6.4.

@targos targos closed this Dec 20, 2017
@cjihrig cjihrig deleted the metadata branch December 20, 2017 13:37
@cjihrig
Copy link
Author

cjihrig commented Dec 20, 2017

Should we document the changes, say, in the Wiki?

I'm inclined to say no, simply because wikis get forgotten about and out of sync. I'm hoping to achieve the same thing in the commit log for the metadata test moving forward though.

nodejs-ci pushed a commit that referenced this pull request Dec 21, 2017
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Dec 21, 2017
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Dec 22, 2017
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Dec 22, 2017
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Dec 23, 2017
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Dec 23, 2017
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 14, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 15, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 16, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 17, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 18, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 18, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 19, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 20, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 21, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 21, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 22, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 23, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 24, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 25, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 26, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 27, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Feb 28, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 1, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 2, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 3, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 4, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 5, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 6, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit that referenced this pull request Mar 7, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: #34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 7, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: nodejs/node-v8#34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Mar 7, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: nodejs/node-v8#34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #18453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This commit updates the following postmortem metadata constants:

- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
  - This is now
    v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
    as of
    v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
  - This is now v8dbg_class_Map__instance_type__uint16_t as of
    v8/v8@c00bb6d
    and
    v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
  - This is now v8dbg_class_Map__instance_size_in_words__char as of
    v8/v8@61bf2cc

Refs: nodejs/node-v8#34

PR-URL: nodejs#17489
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This commit updates the following postmortem metadata constant:

- v8dbg_bit_field3_dictionary_map_shift
  - This is now v8dbg_bit_field3_is_dictionary_map_shift as of
    v8/v8@7a159da

Refs: nodejs/node-v8#34

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs#18453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants