Skip to content

Commit

Permalink
tls: avoid potentially deoptimizing use of arguments
Browse files Browse the repository at this point in the history
Replace use of arguments with `...args`

```
 tls/tls-connect.js dur=5 concurrency=1      -9.43 %            0.172136744
 tls/tls-connect.js dur=5 concurrency=10     29.05 %         ** 0.001108115
```

PR-URL: #11357
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
jasnell committed Feb 15, 2017
1 parent e36d0d3 commit 0000d71
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions lib/_tls_wrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,9 @@ var proxiedMethods = [

// Proxy HandleWrap, PipeWrap and TCPWrap methods
proxiedMethods.forEach(function(name) {
tls_wrap.TLSWrap.prototype[name] = function methodProxy() {
tls_wrap.TLSWrap.prototype[name] = function methodProxy(...args) {
if (this._parent[name])
return this._parent[name].apply(this._parent, arguments);
return this._parent[name].apply(this._parent, args);
};
});

Expand Down Expand Up @@ -986,11 +986,7 @@ function normalizeConnectArgs(listArgs) {
return (cb) ? [options, cb] : [options];
}

exports.connect = function(/* [port,] [host,] [options,] [cb] */) {
const argsLen = arguments.length;
var args = new Array(argsLen);
for (var i = 0; i < argsLen; i++)
args[i] = arguments[i];
exports.connect = function(...args /* [port,] [host,] [options,] [cb] */) {
args = normalizeConnectArgs(args);
var options = args[0];
var cb = args[1];
Expand Down

0 comments on commit 0000d71

Please sign in to comment.