stream: do not error async iterators on destroy(null)

Fixes: #23890 PR-URL: #23901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Oct 28, 2018 · 05d52a4 · 05d52a4
1 parent 4d926d0
commit 05d52a4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/lib/internal/streams/async_iterator.js b/lib/internal/streams/async_iterator.js
@@ -153,7 +153,7 @@ const createReadableStreamAsyncIterator = (stream) => {
   });
 
   finished(stream, (err) => {
-    if (err) {
+    if (err && err.code !== 'ERR_STREAM_PREMATURE_CLOSE') {
       const reject = iterator[kLastReject];
       // reject if we are waiting for data in the Promise
       // returned by next() and store the error

diff --git a/test/parallel/test-stream-readable-async-iterators.js b/test/parallel/test-stream-readable-async-iterators.js
@@ -335,11 +335,8 @@ async function tests() {
 
     readable.destroy();
 
-    try {
-      await readable[Symbol.asyncIterator]().next();
-    } catch (e) {
-      assert.strictEqual(e.code, 'ERR_STREAM_PREMATURE_CLOSE');
-    }
+    const { done } = await readable[Symbol.asyncIterator]().next();
+    assert.strictEqual(done, true);
   })();
 
   await (async function() {
@@ -380,6 +377,22 @@ async function tests() {
     for await (const b of r) {
     }
   })();
+
+  await (async () => {
+    console.log('destroy mid-stream does not error');
+    const r = new Readable({
+      objectMode: true,
+      read() {
+        this.push('asdf');
+        this.push('hehe');
+      }
+    });
+
+    // eslint-disable-next-line no-unused-vars
+    for await (const a of r) {
+      r.destroy(null);
+    }
+  })();
 }
 
 // to avoid missing some tests if a promise does not resolve