src: fix useless call in permission.cc

FromMaybe() has no side effects and the return value is ignored. Instead, if Set() fails, then another exception is pending, so return early.
nodejs · Feb 25, 2023 · 0e95c5a · 0e95c5a
1 parent 347215e
commit 0e95c5a
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/src/permission/permission.cc b/src/permission/permission.cc
@@ -136,22 +136,23 @@ void Permission::ThrowAccessDenied(Environment* env,
                                    const std::string_view& res) {
   Local<Value> err = ERR_ACCESS_DENIED(env->isolate());
   CHECK(err->IsObject());
-  err.As<Object>()
-      ->Set(env->context(),
-            env->permission_string(),
-            v8::String::NewFromUtf8(env->isolate(),
-                                    PermissionToString(perm),
-                                    v8::NewStringType::kNormal)
-                .ToLocalChecked())
-      .FromMaybe(false);
-  err.As<Object>()
-      ->Set(env->context(),
-            env->resource_string(),
-            v8::String::NewFromUtf8(env->isolate(),
-                                    std::string(res).c_str(),
-                                    v8::NewStringType::kNormal)
-                .ToLocalChecked())
-      .FromMaybe(false);
+  if (err.As<Object>()
+          ->Set(env->context(),
+                env->permission_string(),
+                v8::String::NewFromUtf8(env->isolate(),
+                                        PermissionToString(perm),
+                                        v8::NewStringType::kNormal)
+                    .ToLocalChecked())
+          .IsNothing() ||
+      err.As<Object>()
+          ->Set(env->context(),
+                env->resource_string(),
+                v8::String::NewFromUtf8(env->isolate(),
+                                        std::string(res).c_str(),
+                                        v8::NewStringType::kNormal)
+                    .ToLocalChecked())
+          .IsNothing())
+    return;
   env->isolate()->ThrowException(err);
 }