fixup! url: add experimental URLPattern

nodejs · Feb 25, 2022 · 0efafe2 · 0efafe2
1 parent a420bdf
commit 0efafe2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/internal/urlpattern.js b/lib/internal/urlpattern.js
@@ -645,7 +645,7 @@ function tryConsumeModifierToken(parser) {
 function runEncoding(parser, value) {
   if (value === '') return value;
   try {
-    let parseResult = new URL(`${protocol}://dummy.test`);
+    let parseResult = new URL(`${parser.protocol||value}://dummy.test`);
 
     switch (parser.type) {
       case 'protocol':
@@ -689,7 +689,8 @@ function runEncoding(parser, value) {
     }
     // TODO(@jasnell): Throw proper error. Should be an assert
     throw new TypeError('Unknown type');
-  } catch {
+  } catch (err) {
+console.log(err);
     // TODO(@jasnell): Throw proper error
     throw new TypeError(`Invalid ${parser.type}`);
   }

diff --git a/test/parallel/test-urlpattern.js b/test/parallel/test-urlpattern.js
@@ -76,7 +76,7 @@ kTests.forEach((test) => {
 });
 
 {
-//  const pattern = new URLPattern({ pathname: '/books' });
+ const pattern = new URLPattern({ pathname: '/books' });
 //  console.log(pattern.test('https://example.com/books')); // true
 //  console.log(pattern.exec('https://example.com/books').pathname.groups); // {}
 }