Skip to content

Commit

Permalink
test: remove unused common.libDir
Browse files Browse the repository at this point in the history
PR-URL: #9124
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
Trott authored and Myles Borins committed Nov 11, 2016
1 parent bdd91e0 commit 127ed73
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
5 changes: 0 additions & 5 deletions test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,6 @@ Platform check for Windows 32-bit on Windows 64-bit.

Checks whether any globals are not on the `knownGlobals` list.

### libDir
* return [&lt;String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type)

Path to the 'lib' directory.

### localhostIPv4
* return [&lt;String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type)

Expand Down
11 changes: 5 additions & 6 deletions test/common.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* eslint-disable required-modules */
'use strict';
var path = require('path');
var fs = require('fs');
var assert = require('assert');
var os = require('os');
var child_process = require('child_process');
const path = require('path');
const fs = require('fs');
const assert = require('assert');
const os = require('os');
const child_process = require('child_process');
const stream = require('stream');
const util = require('util');
const Timer = process.binding('timer_wrap').Timer;
Expand All @@ -14,7 +14,6 @@ const testRoot = process.env.NODE_TEST_DIR ?

exports.testDir = __dirname;
exports.fixturesDir = path.join(exports.testDir, 'fixtures');
exports.libDir = path.join(exports.testDir, '../lib');
exports.tmpDirName = 'tmp';
// PORT should match the definition in test/testpy/__init__.py.
exports.PORT = +process.env.NODE_COMMON_PORT || 12346;
Expand Down

0 comments on commit 127ed73

Please sign in to comment.