fs: promisify exists correctly

nodejs · May 31, 2017 · 15f3f0b · 15f3f0b
1 parent bb91879
commit 15f3f0b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/fs.js b/lib/fs.js
@@ -28,7 +28,7 @@ const constants = process.binding('constants').fs;
 const { S_IFIFO, S_IFLNK, S_IFMT, S_IFREG, S_IFSOCK } = constants;
 const util = require('util');
 const pathModule = require('path');
-const { isUint8Array } = process.binding('util');
+const { isUint8Array, createPromise, promiseResolve } = process.binding('util');
 
 const binding = process.binding('fs');
 const fs = exports;
@@ -376,6 +376,15 @@ fs.exists = function(path, callback) {
   }
 };
 
+Object.defineProperty(fs.exists, internalUtil.promisify.custom, {
+  value: (path) => {
+    const promise = createPromise();
+    fs.exists(path, (exists) => promiseResolve(promise, exists));
+    return promise;
+  }
+});
+
+
 fs.existsSync = function(path) {
   try {
     handleError((path = getPathFromURL(path)));

diff --git a/test/parallel/test-fs-promisified.js b/test/parallel/test-fs-promisified.js
@@ -9,6 +9,7 @@ common.crashOnUnhandledRejection();
 
 const read = promisify(fs.read);
 const write = promisify(fs.write);
+const exists = promisify(fs.exists);
 
 {
   const fd = fs.openSync(__filename, 'r');
@@ -29,3 +30,9 @@ common.refreshTmpDir();
     fs.closeSync(fd);
   }));
 }
+
+{
+  exists(__filename).then(common.mustCall((x) => {
+    assert.strictEqual(x, true);
+  }));
+}