Skip to content

Commit

Permalink
src: use maybe version v8::Function::Call
Browse files Browse the repository at this point in the history
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
oyyd authored and BethGriggs committed Oct 18, 2019
1 parent 1bb5102 commit 18b140a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/callback_scope.cc
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ void InternalCallbackScope::Close() {

if (!env_->can_call_into_js()) return;

if (env_->tick_callback_function()->Call(process, 0, nullptr).IsEmpty()) {
env_->tick_info()->set_has_thrown(true);
if (env_->tick_callback_function()
->Call(env_->context(), process, 0, nullptr).IsEmpty()) {
failed_ = true;
}
}
Expand Down

0 comments on commit 18b140a

Please sign in to comment.