Skip to content

Commit

Permalink
deps: fix inspector v8 test
Browse files Browse the repository at this point in the history
This fixes the inspector tests failing after the cherry-pick.

V8 commit: https://chromium.googlesource.com/v8/v8/+/f19b889be801bdebc04c49090e37c787f7ba8805
PR-URL: #14827
Fixes: #14824
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
Eugene Ostroukhov authored and MylesBorins committed Sep 12, 2017
1 parent 3d62139 commit 1a2f749
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
7 changes: 7 additions & 0 deletions deps/v8/test/inspector/isolate-data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,10 @@ v8::MaybeLocal<v8::Module> IsolateData::ModuleResolveCallback(
IsolateData* data = IsolateData::FromContext(context);
return data->modules_[ToVector(specifier)].Get(data->isolate_);
}

void IsolateData::FreeContext(v8::Local<v8::Context> context) {
int context_group_id = GetContextGroupId(context);
auto it = contexts_.find(context_group_id);
if (it == contexts_.end()) return;
contexts_.erase(it);
}
1 change: 1 addition & 0 deletions deps/v8/test/inspector/isolate-data.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class IsolateData {
void RegisterModule(v8::Local<v8::Context> context,
v8::internal::Vector<uint16_t> name,
v8::ScriptCompiler::Source* source);
void FreeContext(v8::Local<v8::Context> context);

private:
struct VectorCompare {
Expand Down

0 comments on commit 1a2f749

Please sign in to comment.