Skip to content

Commit

Permalink
test: improve error message in test-tick-processor
Browse files Browse the repository at this point in the history
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information
Trott authored and Myles Borins committed Oct 10, 2016
1 parent 75d13fd commit 1f1eefc
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/parallel/test-tick-processor.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
var fs = require('fs');
var assert = require('assert');
var cp = require('child_process');
var common = require('../common');
const fs = require('fs');
const assert = require('assert');
const cp = require('child_process');
const common = require('../common');

// TODO(mhdawson) Currently the test-tick-processor functionality in V8
// depends on addresses being smaller than a full 64 bits. Aix supports
Expand Down Expand Up @@ -49,12 +49,12 @@ function runTest(pattern, code) {
return /^isolate-/.test(file);
});
if (matches.length != 1) {
assert.fail(null, null, 'There should be a single log file.');
common.fail('There should be a single log file.');
}
var log = matches[0];
var out = cp.execSync(process.execPath +
' --prof-process --call-graph-size=10 ' + log,
{encoding: 'utf8'});
assert(pattern.test(out));
assert(pattern.test(out), `${pattern} not matching ${out}`);
fs.unlinkSync(log);
}

0 comments on commit 1f1eefc

Please sign in to comment.