Skip to content

Commit

Permalink
src: do not include internals from node_buffer.h
Browse files Browse the repository at this point in the history
`node_buffer.h` is a public header, so it should not be using
the `node_internals.h` internal header.

Ref: 290315a
Fixes: #15552
PR-URL: #15554
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information
addaleax authored and jasnell committed Sep 25, 2017
1 parent 2326d65 commit 24271a7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
3 changes: 2 additions & 1 deletion src/node_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
#ifndef SRC_NODE_BUFFER_H_
#define SRC_NODE_BUFFER_H_

#include "node_internals.h"
#include "node.h"
#include "v8.h"

namespace node {

Expand Down
5 changes: 1 addition & 4 deletions src/node_serdes.cc
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
#include "node.h"
#include "node_internals.h"
#include "node_buffer.h"
#include "base-object.h"
#include "base-object-inl.h"
#include "env.h"
#include "env-inl.h"
#include "v8.h"

namespace node {

Expand Down
2 changes: 1 addition & 1 deletion src/spawn_sync.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "node.h"
#include "node_internals.h"
#include "node_buffer.h"

namespace node {
Expand Down
3 changes: 1 addition & 2 deletions src/string_bytes.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@
#include "string_bytes.h"

#include "base64.h"
#include "node.h"
#include "node_internals.h"
#include "node_buffer.h"
#include "v8.h"

#include <limits.h>
#include <string.h> // memcpy
Expand Down

0 comments on commit 24271a7

Please sign in to comment.