Skip to content

Commit

Permalink
test: temporarily skip flaky test on freebsd
Browse files Browse the repository at this point in the history
The final segment of the test_object/test.js fails for some
as yet unknown reason, only on freebsd, with this PR, despite
the test being completely unrelated to the test.

This temporarily skips the segment on freebsd until the cause
can be determined.

Signed-off-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
jasnell committed Mar 24, 2021
1 parent 99f1670 commit 24c93f2
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions test/js-native-api/test_object/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,16 @@ assert.deepStrictEqual(test_object.TestGetProperty(), {
obj.x = 'd';
}

// TODO(@jasnell): For some reason that is as yet unknown,
// https://github.com/nodejs/node/pull/37786, which makes the
// atob and btoa functions global, causes this test to fail
// persistently on FreeBSD, and only on FreeBSD, despite the
// fact that https://github.com/nodejs/node/pull/37786 does
// not touch anything that should impact this test and this
// test does not use atob or btoa at all.
if (common.isFreeBSD)
common.skip('Skips bits that are failing on FreeBSD for no obvious reason.');

{
const obj = { x: 10, y: 10, z: 10 };

Expand Down

0 comments on commit 24c93f2

Please sign in to comment.