test: close fds properly in tests

Otherwise the unclosed fd may keep the file open which makes subsequent rmdir attempts failed at exit.
nodejs · Jun 1, 2021 · 2a1aec2 · 2a1aec2
1 parent a4ea9fc
commit 2a1aec2
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/test/parallel/test-fs-writefile-with-fd.js b/test/parallel/test-fs-writefile-with-fd.js
@@ -65,7 +65,10 @@ tmpdir.refresh();
   const file = join(tmpdir.path, 'test.txt');
 
   fs.open(file, 'r', common.mustSucceed((fd) => {
-    fs.writeFile(fd, 'World', common.expectsError(expectedError));
+    fs.writeFile(fd, 'World', common.mustCall((err) => {
+      fs.closeSync(fd);
+      common.expectsError(expectedError)(err);
+    }));
   }));
 }
 
@@ -76,8 +79,11 @@ tmpdir.refresh();
   const file = join(tmpdir.path, 'test.txt');
 
   fs.open(file, 'w', common.mustSucceed((fd) => {
-    fs.writeFile(fd, 'World', { signal }, common.expectsError({
-      name: 'AbortError'
+    fs.writeFile(fd, 'World', { signal }, common.mustCall((err) => {
+      fs.closeSync(fd);
+      common.expectsError({
+        name: 'AbortError'
+      })(err);
     }));
   }));