squash: simplify copying from ArrayBufferView

nodejs · May 28, 2022 · 2b328c8 · 2b328c8
1 parent bfcb4f4
commit 2b328c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/lib/tls.js b/lib/tls.js
@@ -150,9 +150,7 @@ exports.convertALPNProtocols = function convertALPNProtocols(protocols, out) {
     // Copy new buffer not to be modified by user.
     out.ALPNProtocols = Buffer.from(protocols);
   } else if (isArrayBufferView(protocols)) {
-    out.ALPNProtocols = Buffer.from(protocols.buffer.slice(),
-                                    protocols.byteOffset,
-                                    protocols.byteLength);
+    out.ALPNProtocols = Buffer.from(protocols.slice().buffer);
   }
 };
 

diff --git a/test/parallel/test-tls-basic-validations.js b/test/parallel/test-tls-basic-validations.js
@@ -103,11 +103,8 @@ assert.throws(
   const inputBuffer = Buffer.from(arrayBufferViewStr.repeat(8), 'utf8');
   for (const expectView of common.getArrayBufferViews(inputBuffer)) {
     const out = {};
-    const expected = Buffer.from(expectView.buffer.slice(),
-                                 expectView.byteOffset,
-                                 expectView.byteLength);
     tls.convertALPNProtocols(expectView, out);
-    assert(out.ALPNProtocols.equals(expected));
+    assert(out.ALPNProtocols.equals(Buffer.from(expectView.slice().buffer)));
   }
 }