Skip to content

Commit

Permalink
test: fail for missing output files
Browse files Browse the repository at this point in the history
Instead of ignoring missing `.out` files for message/pseudo-tty tests,
raise an error to indicate that something is not quite right.

Ref: #10037
PR-URL: #10150
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
addaleax authored and MylesBorins committed Jan 23, 2017
1 parent 8f4c29b commit 2f7270a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions test/message/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ def ListTests(self, current_path, path, arch, mode):
file_path = file_prefix + ".js"
output_path = file_prefix + ".out"
if not exists(output_path):
print "Could not find %s" % output_path
continue
raise Exception("Could not find %s" % output_path)
result.append(MessageTestCase(test, file_path, output_path,
arch, mode, self.context, self))
return result
Expand Down
3 changes: 1 addition & 2 deletions test/pseudo-tty/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ def ListTests(self, current_path, path, arch, mode):
file_path = file_prefix + ".js"
output_path = file_prefix + ".out"
if not exists(output_path):
print "Could not find %s" % output_path
continue
raise Exception("Could not find %s" % output_path)
result.append(TTYTestCase(test, file_path, output_path,
arch, mode, self.context, self))
return result
Expand Down

0 comments on commit 2f7270a

Please sign in to comment.