benchmark: use strict mode

Apply strict mode to benchmark code.

PR-URL: #5336
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

benchmark/arrays/var-int.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   type: 'Array Buffer Int8Array Uint8Array Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array'.split(' '),

benchmark/arrays/zero-float.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   type: 'Array Buffer Int8Array Uint8Array Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array'.split(' '),

benchmark/arrays/zero-int.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   type: 'Array Buffer Int8Array Uint8Array Int16Array Uint16Array Int32Array Uint32Array Float32Array Float64Array'.split(' '),

benchmark/buffers/buffer-base64-decode.js

@@ -1,3 +1,4 @@
+'use strict';
 var assert = require('assert');
 var common = require('../common.js');
 

benchmark/buffers/buffer-base64-encode.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 
 var bench = common.createBenchmark(main, {});

benchmark/buffers/buffer-bytelength.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common');
 
 var bench = common.createBenchmark(main, {

benchmark/buffers/buffer-compare.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 
 var bench = common.createBenchmark(main, {

benchmark/buffers/buffer-creation.js

@@ -1,4 +1,5 @@
-SlowBuffer = require('buffer').SlowBuffer;
+'use strict';
+const SlowBuffer = require('buffer').SlowBuffer;
 
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {

benchmark/buffers/buffer-indexof.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var fs = require('fs');
 

benchmark/buffers/buffer-iterate.js

@@ -1,3 +1,4 @@
+'use strict';
 var SlowBuffer = require('buffer').SlowBuffer;
 var common = require('../common.js');
 var assert = require('assert');

benchmark/buffers/buffer-read.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 
 var bench = common.createBenchmark(main, {

benchmark/buffers/buffer-slice.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var SlowBuffer = require('buffer').SlowBuffer;
 

benchmark/buffers/buffer-write.js

@@ -1,4 +1,4 @@
-
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   noAssert: [false, true],

benchmark/buffers/dataview-set.js

@@ -1,4 +1,4 @@
-
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   type: ['Uint8', 'Uint16LE', 'Uint16BE',

benchmark/common.js

@@ -1,3 +1,4 @@
+'use strict';
 var assert = require('assert');
 var fs = require('fs');
 var path = require('path');

benchmark/compare.js

@@ -1,3 +1,4 @@
+'use strict';
 var usage = 'node benchmark/compare.js ' +
             '<node-binary1> <node-binary2> ' +
             '[--html] [--red|-r] [--green|-g] ' +
@@ -38,9 +39,9 @@ for (var i = 2; i < process.argv.length; i++) {
 
 if (!html) {
   var start = '';
-  var green = '\033[1;32m';
-  var red = '\033[1;31m';
-  var reset = '\033[m';
+  var green = '\u001b[1;32m';
+  var red = '\u001b[1;31m';
+  var reset = '\u001b[m';
   var end = '';
 } else {
   var start = '<pre style="background-color:#333;color:#eee">';

benchmark/crypto/aes-gcm-throughput.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var crypto = require('crypto');
 var keylen = {'aes-128-gcm': 16, 'aes-192-gcm': 24, 'aes-256-gcm': 32};

benchmark/crypto/cipher-stream.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 
 var bench = common.createBenchmark(main, {

benchmark/crypto/hash-stream-creation.js

@@ -1,5 +1,6 @@
 // throughput benchmark
 // creates a single hasher, then pushes a bunch of data through it
+'use strict';
 var common = require('../common.js');
 var crypto = require('crypto');
 

benchmark/crypto/hash-stream-throughput.js

@@ -1,5 +1,6 @@
 // throughput benchmark
 // creates a single hasher, then pushes a bunch of data through it
+'use strict';
 var common = require('../common.js');
 var crypto = require('crypto');
 

benchmark/crypto/rsa-encrypt-decrypt-throughput.js

@@ -1,3 +1,4 @@
+'use strict';
 // throughput benchmark in signing and verifying
 var common = require('../common.js');
 var crypto = require('crypto');

benchmark/crypto/rsa-sign-verify-throughput.js

@@ -1,3 +1,4 @@
+'use strict';
 // throughput benchmark in signing and verifying
 var common = require('../common.js');
 var crypto = require('crypto');

benchmark/events/ee-add-remove.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var events = require('events');
 

benchmark/events/ee-emit-multi-args.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var EventEmitter = require('events').EventEmitter;
 

benchmark/events/ee-emit.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var EventEmitter = require('events').EventEmitter;
 

benchmark/events/ee-listener-count-on-prototype.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var EventEmitter = require('events').EventEmitter;
 

benchmark/events/ee-listeners-many.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var EventEmitter = require('events').EventEmitter;
 

benchmark/events/ee-listeners.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var EventEmitter = require('events').EventEmitter;
 

benchmark/fs-write-stream-throughput.js

@@ -1,5 +1,5 @@
-
 // If there are no args, then this is the root.  Run all the benchmarks!
+'use strict';
 if (!process.argv[2])
   parent();
 else

benchmark/fs/read-stream-throughput.js

@@ -1,4 +1,5 @@
 // test the throughput of the fs.WriteStream class.
+'use strict';
 
 var path = require('path');
 var common = require('../common.js');

benchmark/fs/readfile.js

@@ -1,6 +1,7 @@
 // Call fs.readFile over and over again really fast.
 // Then see how many times it got called.
 // Yes, this is a silly benchmark.  Most benchmarks are silly.
+'use strict';
 
 var path = require('path');
 var common = require('../common.js');

benchmark/fs/write-stream-throughput.js

@@ -1,4 +1,5 @@
 // test the throughput of the fs.WriteStream class.
+'use strict';
 
 var path = require('path');
 var common = require('../common.js');

benchmark/http/chunked.js

@@ -6,6 +6,7 @@
 // always as hot as it could be.
 //
 // Verify that our assumptions are valid.
+'use strict';
 
 var common = require('../common.js');
 var PORT = common.PORT;
@@ -17,7 +18,7 @@ var bench = common.createBenchmark(main, {
 });
 
 function main(conf) {
-  http = require('http');
+  const http = require('http');
   var chunk = new Buffer(conf.size);
   chunk.fill('8');
 

benchmark/http/client-request-body.js

@@ -1,4 +1,5 @@
 // Measure the time it takes for the HTTP client to send a request body.
+'use strict';
 
 var common = require('../common.js');
 var http = require('http');

benchmark/http/cluster.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var PORT = common.PORT;
 

benchmark/http/end-vs-write-end.js

@@ -6,6 +6,7 @@
 // always as hot as it could be.
 //
 // Verify that our assumptions are valid.
+'use strict';
 
 var common = require('../common.js');
 var PORT = common.PORT;
@@ -18,7 +19,7 @@ var bench = common.createBenchmark(main, {
 });
 
 function main(conf) {
-  http = require('http');
+  const http = require('http');
   var chunk;
   var len = conf.kb * 1024;
   switch (conf.type) {
@@ -27,7 +28,6 @@ function main(conf) {
       chunk.fill('x');
       break;
     case 'utf':
-      encoding = 'utf8';
       chunk = new Array(len / 2 + 1).join('ü');
       break;
     case 'asc':

benchmark/http/simple.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var PORT = common.PORT;
 

benchmark/http_bench.js

@@ -1,3 +1,4 @@
+'use strict';
 var spawn = require('child_process').spawn;
 var cluster = require('cluster');
 var http = require('http');

benchmark/http_server_lag.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var http = require('http');
 var port = parseInt(process.env.PORT, 10) || 8000;
 var defaultLag = parseInt(process.argv[2], 10) || 100;

benchmark/http_simple.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var path = require('path'),
     exec = require('child_process').exec,
     http = require('http');

benchmark/http_simple_auto.js

@@ -6,6 +6,7 @@
 //   <args>   Arguments to pass to `ab`.
 //   <target> Target to benchmark, e.g. `bytes/1024` or `buffer/8192`.
 //
+'use strict';
 
 var path = require("path");
 var http = require("http");

benchmark/http_simple_cluster.js

@@ -1,3 +1,4 @@
+'use strict';
 var cluster = require('cluster');
 var os = require('os');
 

benchmark/idle_clients.js

@@ -1,4 +1,5 @@
-net = require('net');
+'use strict';
+const net = require('net');
 
 var errors = 0, connections = 0;
 

benchmark/misc/child-process-read.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   len: [64, 256, 1024, 4096, 32768],

benchmark/misc/domain-fn-args.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var domain = require('domain');
 
@@ -12,13 +13,13 @@ var gargs = [1, 2, 3];
 function main(conf) {
 
   var args, ret, n = +conf.n;
-  var arguments = gargs.slice(0, conf.arguments);
+  var myArguments = gargs.slice(0, conf.arguments);
   bench.start();
 
   bdomain.enter();
   for (var i = 0; i < n; i++) {
-    if (arguments.length >= 2) {
-      args = Array.prototype.slice.call(arguments, 1);
+    if (myArguments.length >= 2) {
+      args = Array.prototype.slice.call(myArguments, 1);
       ret = fn.apply(this, args);
     } else {
       ret = fn.call(this);

benchmark/misc/function_call/index.js

@@ -2,6 +2,7 @@
 // relative to a comparable C++ function.
 // Reports millions of calls per second.
 // Note that JS speed goes up, while cxx speed stays about the same.
+'use strict';
 
 var assert = require('assert');
 var common = require('../../common.js');

benchmark/misc/module-loader.js

@@ -1,3 +1,4 @@
+'use strict';
 var fs = require('fs');
 var path = require('path');
 var common = require('../common.js');

benchmark/misc/next-tick-breadth.js

@@ -1,3 +1,4 @@
+'use strict';
 
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {

benchmark/misc/next-tick-depth.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   millions: [2]

benchmark/misc/spawn-echo.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {
   thousands: [1]

benchmark/misc/startup.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var spawn = require('child_process').spawn;
 var path = require('path');

benchmark/misc/string-creation.js

@@ -1,3 +1,4 @@
+'use strict';
 
 var common = require('../common.js');
 var bench = common.createBenchmark(main, {

benchmark/misc/string-decoder.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 var StringDecoder = require('string_decoder').StringDecoder;
 

benchmark/misc/timers.js

@@ -1,3 +1,4 @@
+'use strict';
 var common = require('../common.js');
 
 var bench = common.createBenchmark(main, {

benchmark/misc/url.js

@@ -1,3 +1,4 @@
+'use strict';
 var url = require('url')
 var n = 25 * 100;
 

benchmark/misc/v8-bench.js

@@ -1,4 +1,5 @@
 // compare with "google-chrome deps/v8/benchmarks/run.html"
+'use strict';
 var fs = require('fs');
 var path = require('path');
 var vm = require('vm');

benchmark/net/net-c2s-cork.js

@@ -1,4 +1,5 @@
 // test the speed of .pipe() with sockets
+'use strict';
 
 var common = require('../common.js');
 var PORT = common.PORT;

benchmark/net/net-c2s.js

@@ -1,4 +1,5 @@
 // test the speed of .pipe() with sockets
+'use strict';
 
 var common = require('../common.js');
 var PORT = common.PORT;

benchmark/net/net-pipe.js

@@ -1,4 +1,5 @@
 // test the speed of .pipe() with sockets
+'use strict';
 
 var common = require('../common.js');
 var PORT = common.PORT;

benchmark/net/net-s2c.js

@@ -1,4 +1,5 @@
 // test the speed of .pipe() with sockets
+'use strict';
 
 var common = require('../common.js');
 var PORT = common.PORT;

benchmark/net/tcp-raw-c2s.js

@@ -1,5 +1,6 @@
 // In this benchmark, we connect a client to the server, and write
 // as many bytes as we can in the specified time (default = 10s)
+'use strict';
 
 var common = require('../common.js');
 var util = require('util');